From ecc7c0d817c176af094ae10e2c3227049b1650a3 Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Wed, 7 Mar 2012 23:52:51 +0000 Subject: [PATCH] Moved inline functions into SBTarget.cpp and made destructors for SBLaunchInfo and SBAttachInfo to avoid link warnings. llvm-svn: 152267 --- lldb/include/lldb/API/SBTarget.h | 14 ++++++-------- lldb/source/API/SBTarget.cpp | 29 +++++++++++++++++++++++++---- 2 files changed, 31 insertions(+), 12 deletions(-) diff --git a/lldb/include/lldb/API/SBTarget.h b/lldb/include/lldb/API/SBTarget.h index 0c9af2ab5cf8..0d09c3188101 100644 --- a/lldb/include/lldb/API/SBTarget.h +++ b/lldb/include/lldb/API/SBTarget.h @@ -25,6 +25,8 @@ class SBLaunchInfo public: SBLaunchInfo (const char **argv); + ~SBLaunchInfo(); + uint32_t GetUserID(); @@ -110,10 +112,7 @@ protected: friend class SBTarget; lldb_private::ProcessLaunchInfo & - ref () - { - return *m_opaque_sp; - } + ref (); ProcessLaunchInfoSP m_opaque_sp; }; @@ -129,6 +128,8 @@ public: SBAttachInfo (const SBAttachInfo &rhs); + ~SBAttachInfo(); + SBAttachInfo & operator = (const SBAttachInfo &rhs); @@ -212,10 +213,7 @@ protected: friend class SBTarget; lldb_private::ProcessAttachInfo & - ref () - { - return *m_opaque_sp; - } + ref (); ProcessAttachInfoSP m_opaque_sp; }; diff --git a/lldb/source/API/SBTarget.cpp b/lldb/source/API/SBTarget.cpp index 33b659b75487..4d7b828dd51e 100644 --- a/lldb/source/API/SBTarget.cpp +++ b/lldb/source/API/SBTarget.cpp @@ -63,6 +63,17 @@ SBLaunchInfo::SBLaunchInfo (const char **argv) : m_opaque_sp->GetArguments().SetArguments(argv); } +SBLaunchInfo::~SBLaunchInfo() +{ +} + +lldb_private::ProcessLaunchInfo & +SBLaunchInfo::ref () +{ + return *m_opaque_sp; +} + + uint32_t SBLaunchInfo::GetUserID() { @@ -249,18 +260,18 @@ SBLaunchInfo::AddSuppressFileAction (int fd, bool read, bool write) SBAttachInfo::SBAttachInfo () : -m_opaque_sp (new ProcessAttachInfo()) + m_opaque_sp (new ProcessAttachInfo()) { } SBAttachInfo::SBAttachInfo (lldb::pid_t pid) : -m_opaque_sp (new ProcessAttachInfo()) + m_opaque_sp (new ProcessAttachInfo()) { m_opaque_sp->SetProcessID (pid); } SBAttachInfo::SBAttachInfo (const char *path, bool wait_for) : -m_opaque_sp (new ProcessAttachInfo()) + m_opaque_sp (new ProcessAttachInfo()) { if (path && path[0]) m_opaque_sp->GetExecutableFile().SetFile(path, false); @@ -268,11 +279,21 @@ m_opaque_sp (new ProcessAttachInfo()) } SBAttachInfo::SBAttachInfo (const SBAttachInfo &rhs) : -m_opaque_sp (new ProcessAttachInfo()) + m_opaque_sp (new ProcessAttachInfo()) { *m_opaque_sp = *rhs.m_opaque_sp; } +SBAttachInfo::~SBAttachInfo() +{ +} + +lldb_private::ProcessAttachInfo & +SBAttachInfo::ref () +{ + return *m_opaque_sp; +} + SBAttachInfo & SBAttachInfo::operator = (const SBAttachInfo &rhs) {