From eba02fecdd3063960091de39853b07225d03381d Mon Sep 17 00:00:00 2001 From: Douglas Gregor Date: Fri, 13 Apr 2012 15:53:08 +0000 Subject: [PATCH] super and class property reference expressions don't need to be rebuilt. Fixes . llvm-svn: 154667 --- clang/lib/Sema/SemaPseudoObject.cpp | 9 +++++++-- clang/test/SemaObjCXX/property-reference.mm | 15 +++++++++++++++ 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/clang/lib/Sema/SemaPseudoObject.cpp b/clang/lib/Sema/SemaPseudoObject.cpp index d52c912457a1..3b2cf8d7350e 100644 --- a/clang/lib/Sema/SemaPseudoObject.cpp +++ b/clang/lib/Sema/SemaPseudoObject.cpp @@ -1300,8 +1300,13 @@ static Expr *stripOpaqueValuesFromPseudoObjectRef(Sema &S, Expr *E) { Expr *opaqueRef = E->IgnoreParens(); if (ObjCPropertyRefExpr *refExpr = dyn_cast(opaqueRef)) { - OpaqueValueExpr *baseOVE = cast(refExpr->getBase()); - return ObjCPropertyRefRebuilder(S, baseOVE->getSourceExpr()).rebuild(E); + if (refExpr->isObjectReceiver()) { + OpaqueValueExpr *baseOVE = cast(refExpr->getBase()); + return ObjCPropertyRefRebuilder(S, baseOVE->getSourceExpr()).rebuild(E); + } + + // Neither class or super property references need a rebuild. + return E; } else if (ObjCSubscriptRefExpr *refExpr = dyn_cast(opaqueRef)) { OpaqueValueExpr *baseOVE = cast(refExpr->getBaseExpr()); diff --git a/clang/test/SemaObjCXX/property-reference.mm b/clang/test/SemaObjCXX/property-reference.mm index 18f06045a340..b86ae5e9f51d 100644 --- a/clang/test/SemaObjCXX/property-reference.mm +++ b/clang/test/SemaObjCXX/property-reference.mm @@ -42,3 +42,18 @@ typedef const TCPPObject& CREF_TCPPObject; cppObjectNonAtomic = cppObject; } @end + + +// +@interface NSObject ++ alloc; +- init; +- class; +@end + +template void f() { + NSObject *o = [NSObject.alloc init]; + [o class]; +} + +template void f();