From ea5c4bd51cddaf318e23ab13661def6f9d918066 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Mon, 25 Jun 2007 21:50:09 +0000 Subject: [PATCH] fix Transforms/Inline/2007-06-25-WeakInline.ll by not inlining functions with weak linkage. llvm-svn: 37723 --- llvm/lib/Transforms/IPO/InlineSimple.cpp | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/llvm/lib/Transforms/IPO/InlineSimple.cpp b/llvm/lib/Transforms/IPO/InlineSimple.cpp index 83cfe901a09f..2157dcd2fec8 100644 --- a/llvm/lib/Transforms/IPO/InlineSimple.cpp +++ b/llvm/lib/Transforms/IPO/InlineSimple.cpp @@ -195,10 +195,14 @@ int SimpleInliner::getInlineCost(CallSite CS) { const Function *Caller = TheCall->getParent()->getParent(); // Don't inline a directly recursive call. - if (Caller == Callee) return 2000000000; - - // Don't inline functions marked noinline - if (NeverInline.count(Callee)) return 2000000000; + if (Caller == Callee || + // Don't inline functions which can be redefined at link-time to mean + // something else. link-once linkage is ok though. + Callee->hasWeakLinkage() || + + // Don't inline functions marked noinline. + NeverInline.count(Callee)) + return 2000000000; // InlineCost - This value measures how good of an inline candidate this call // site is to inline. A lower inline cost make is more likely for the call to