From ea3f97d27843acb281e663c80f138f78c2a99a79 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Thu, 4 Apr 2019 13:37:15 +0000 Subject: [PATCH] Try to suppress nodiscard_extension failures with Xcode 9 See https://crbug.com/949509 for the error message. llvm-svn: 357692 --- libcxx/test/libcxx/diagnostics/nodiscard_extensions.fail.cpp | 4 ++++ libcxx/test/libcxx/diagnostics/nodiscard_extensions.pass.cpp | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/libcxx/test/libcxx/diagnostics/nodiscard_extensions.fail.cpp b/libcxx/test/libcxx/diagnostics/nodiscard_extensions.fail.cpp index 543fd2456f65..10582b9378ba 100644 --- a/libcxx/test/libcxx/diagnostics/nodiscard_extensions.fail.cpp +++ b/libcxx/test/libcxx/diagnostics/nodiscard_extensions.fail.cpp @@ -12,6 +12,10 @@ // GCC versions prior to 7.0 don't provide the required [[nodiscard]] attribute. // UNSUPPORTED: gcc-4, gcc-5, gcc-6 +// AppleClang9 doesn't yet support C++17's implicitly synthesized deduction +// guides from existing ctors, needed by default_searcher() below. +// UNSUPPORTED: apple-clang-9 + // Test that entities declared [[nodiscard]] as at extension by libc++, are // only actually declared such when _LIBCPP_ENABLE_NODISCARD is specified. diff --git a/libcxx/test/libcxx/diagnostics/nodiscard_extensions.pass.cpp b/libcxx/test/libcxx/diagnostics/nodiscard_extensions.pass.cpp index e06ad97d97a3..c4d6016d7e1c 100644 --- a/libcxx/test/libcxx/diagnostics/nodiscard_extensions.pass.cpp +++ b/libcxx/test/libcxx/diagnostics/nodiscard_extensions.pass.cpp @@ -13,6 +13,10 @@ // This test intentionally leaks memory, so it is unsupported under ASAN. // UNSUPPORTED: asan +// AppleClang9 doesn't yet support C++17's implicitly synthesized deduction +// guides from existing ctors, needed by default_searcher() below. +// UNSUPPORTED: apple-clang-9 + // All entities to which libc++ applies [[nodiscard]] as an extension should // be tested here and in nodiscard_extensions.fail.cpp. They should also // be listed in `UsingLibcxx.rst` in the documentation for the extension.