replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[clangd] Enable completion index by default, limit results to 100. 

Summary:
This should speed up global code completion by avoiding deserializing
preamble declarations to look up names. The tradeoff is memory usage.
Currently the index is fairly naive and may not be much faster, but there's lots
of performance headroom.

These two changes go together because results from the index get copied a couple
of times, so we should avoid it for huge sets.

Also the flag should be -completion-limit, rather than -limit-completion.

Reviewers: hokein, ioeric, ilya-biryukov

Subscribers: klimek, jkorous-apple, cfe-commits

Differential Revision: https://reviews.llvm.org/D42669

llvm-svn: 323734
This commit is contained in:
Sam McCall 2018-01-30 09:21:30 +00:00
parent f72e865372
commit ea283c7bb8
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
clang-tools-extra/clangd/tool/ClangdMain.cpp
View File

@ -87,10 +87,10 @@ static llvm::cl::opt<PCHStorageFlag> PCHStorage(
llvm::cl::init(PCHStorageFlag::Disk));
static llvm::cl::opt<int> LimitCompletionResult(
"limit-completion",
"completion-limit",
llvm::cl::desc("Limit the number of completion results returned by clangd. "
"0 means no limit."),
llvm::cl::init(0));
llvm::cl::init(100));
static llvm::cl::opt<bool> RunSynchronously(
"run-synchronously",
@ -117,9 +117,9 @@ static llvm::cl::opt<Path> TraceFile(
static llvm::cl::opt<bool> EnableIndexBasedCompletion(
"enable-index-based-completion",
llvm::cl::desc(
"Enable index-based global code completion (experimental). Clangd will "
"use index built from symbols in opened files"),
llvm::cl::init(false), llvm::cl::Hidden);
"Enable index-based global code completion. "
"Clang uses an index built from symbols in opened files"),
llvm::cl::init(true));
static llvm::cl::opt<Path> YamlSymbolFile(
"yaml-symbol-file",