replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[ADT] Enable ArrayRef/StringRef is_assignable tests on MSVC 

Now that we've dropped VS2015 support (D64326) we can enable these static_asserts on MSVC builds as VS2017+ correctly handles them

llvm-svn: 365471
This commit is contained in:
Simon Pilgrim 2019-07-09 12:20:04 +00:00
parent 4bc20fa149
commit e995ce5498
2 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
llvm/unittests/ADT/ArrayRefTest.cpp
View File

@ -33,10 +33,6 @@ static_assert(
// Check that we can't accidentally assign a temporary location to an ArrayRef.
// (Unfortunately we can't make use of the same thing with constructors.)
//
// Disable this check under MSVC; even MSVC 2015 isn't inconsistent between
// std::is_assignable and actually writing such an assignment.
#if !defined(_MSC_VER)
static_assert(
!std::is_assignable<ArrayRef<int *>&, int *>::value,
"Assigning from single prvalue element");
@ -49,7 +45,6 @@ static_assert(
static_assert(
!std::is_assignable<ArrayRef<int *>&, std::initializer_list<int *>>::value,
"Assigning from an initializer list");
#endif
namespace {

6
llvm/unittests/ADT/StringRefTest.cpp
View File

@ -34,10 +34,6 @@ std::ostream &operator<<(std::ostream &OS,
// Check that we can't accidentally assign a temporary std::string to a
// StringRef. (Unfortunately we can't make use of the same thing with
// constructors.)
//
// Disable this check under MSVC; even MSVC 2015 isn't consistent between
// std::is_assignable and actually writing such an assignment.
#if !defined(_MSC_VER)
static_assert(
!std::is_assignable<StringRef&, std::string>::value,
"Assigning from prvalue std::string");
@ -56,8 +52,6 @@ static_assert(
static_assert(
std::is_assignable<StringRef&, const char * &>::value,
"Assigning from lvalue C string");
#endif
namespace {
TEST(StringRefTest, Construction) {