Clean up linux test decorators and add links to known bugs

- s/skipOnLinux/skipIfLinux/ to match style of every other decorator
- linkify bugizilla/PR numbers in comments

No intended change in functionality.

llvm-svn: 181913
This commit is contained in:
Daniel Malea 2013-05-15 18:48:32 +00:00
parent 5c42d8a87c
commit e8bdd1f5c0
41 changed files with 52 additions and 52 deletions

View File

@ -26,7 +26,7 @@ class ExprCommandCallFunctionTestCase(TestBase):
self.call_function()
@dwarf_test
@expectedFailureGcc # bugzilla 14437, fails with GCC 4.6.3 and 4.7.2
@expectedFailureGcc # llvm.org/pr14437, fails with GCC 4.6.3 and 4.7.2
def test_with_dwarf(self):
"""Test calling std::String member function."""
self.buildDwarf()

View File

@ -26,7 +26,7 @@ class ExprCommandWithTimeoutsTestCase(TestBase):
self.buildDsym()
self.call_function()
@skipOnLinux # PR-15278: handle expressions that generate signals on Linux
@skipIfLinux # llvm.org/pr15278: handle expressions that generate signals on Linux
@dwarf_test
def test_with_dwarf(self):
"""Test calling std::String member function."""

View File

@ -20,7 +20,7 @@ class Radar9673644TestCase(TestBase):
self.line = line_number(self.main_source, '// Set breakpoint here.')
# rdar://problem/9673664
@skipOnLinux # PR-14805: expressions that require memory allocation evaluate incorrectly on Linux
@skipIfLinux # llvm.org/pr14805: expressions that require memory allocation evaluate incorrectly on Linux
def test_expr_commands(self):
"""The following expression commands should just work."""
self.buildDefault()

View File

@ -18,7 +18,7 @@ class CmdPythonTestCase(TestBase):
self.pycmd_tests ()
@dwarf_test
@skipOnLinux # causes buildbot failures, skip until we can investigate it
@skipIfLinux # causes buildbot failures, skip until we can investigate it
def test_with_dwarf (self):
self.buildDwarf ()
self.pycmd_tests ()

View File

@ -10,7 +10,7 @@ class ImportTestCase(TestBase):
mydir = os.path.join("functionalities", "command_script", "import")
@python_api_test
@skipOnLinux # causes buildbot failures, skip until we can investigate it
@skipIfLinux # causes buildbot failures, skip until we can investigate it
def test_import_command(self):
"""Import some Python scripts by path and test them"""
self.run_test()

View File

@ -34,7 +34,7 @@ class CommandLineCompletionTestCase(TestBase):
self.complete_from_to('process attach --con', 'process attach --continue ')
# <rdar://problem/11052829>
@skipOnLinux # llvm.org/pr14637: this test case fails (with GCC 4.6 but not clang) because the input prompt "(lldb)" is missing
@skipIfLinux # llvm.org/pr14637: this test case fails (with GCC 4.6 but not clang) because the input prompt "(lldb)" is missing
def test_infinite_loop_while_completing(self):
"""Test that 'process print hello\' completes to itself and does not infinite loop."""
self.complete_from_to('process print hello\\', 'process print hello\\',

View File

@ -40,7 +40,7 @@ class ConditionalBreakTestCase(TestBase):
self.simulate_conditional_break_by_user()
@dwarf_test
@skipOnLinux # due to two assertion failures introduced by r174793: ProcessPOSIX.cpp:223 (assertion 'state == eStateStopped || state == eStateCrashed') and POSIXThread.cpp:254 (assertion 'bp_site')
@skipIfLinux # due to two assertion failures introduced by r174793: ProcessPOSIX.cpp:223 (assertion 'state == eStateStopped || state == eStateCrashed') and POSIXThread.cpp:254 (assertion 'bp_site')
def test_with_dwarf_command(self):
"""Simulate a user using lldb commands to break on c() if called from a()."""
self.buildDwarf()

View File

@ -19,7 +19,7 @@ class LibcxxIteratorDataFormatterTestCase(TestBase):
self.buildDsym()
self.data_formatter_commands()
@skipOnLinux # No standard locations for libc++ on Linux, so skip for now
@skipIfLinux # No standard locations for libc++ on Linux, so skip for now
@dwarf_test
def test_with_dwarf_and_run_command(self):
"""Test data formatter commands."""

View File

@ -19,7 +19,7 @@ class LibcxxListDataFormatterTestCase(TestBase):
self.buildDsym()
self.data_formatter_commands()
@skipOnLinux # No standard locations for libc++ on Linux, so skip for now
@skipIfLinux # No standard locations for libc++ on Linux, so skip for now
@dwarf_test
def test_with_dwarf_and_run_command(self):
"""Test data formatter commands."""

View File

@ -19,7 +19,7 @@ class LibcxxMapDataFormatterTestCase(TestBase):
self.buildDsym()
self.data_formatter_commands()
@skipOnLinux # No standard locations for libc++ on Linux, so skip for now
@skipIfLinux # No standard locations for libc++ on Linux, so skip for now
@dwarf_test
def test_with_dwarf_and_run_command(self):
"""Test data formatter commands."""

View File

@ -20,7 +20,7 @@ class LibcxxStringDataFormatterTestCase(TestBase):
self.buildDsym()
self.data_formatter_commands()
@skipOnLinux # No standard locations for libc++ on Linux, so skip for now
@skipIfLinux # No standard locations for libc++ on Linux, so skip for now
@dwarf_test
def test_with_dwarf_and_run_command(self):
"""Test data formatter commands."""

View File

@ -19,7 +19,7 @@ class LibcxxVBoolDataFormatterTestCase(TestBase):
self.buildDsym()
self.data_formatter_commands()
@skipOnLinux # No standard locations for libc++ on Linux, so skip for now
@skipIfLinux # No standard locations for libc++ on Linux, so skip for now
@dwarf_test
def test_with_dwarf_and_run_command(self):
"""Test data formatter commands."""

View File

@ -19,7 +19,7 @@ class LibcxxVectorDataFormatterTestCase(TestBase):
self.buildDsym()
self.data_formatter_commands()
@skipOnLinux # No standard locations for libc++ on Linux, so skip for now
@skipIfLinux # No standard locations for libc++ on Linux, so skip for now
@dwarf_test
def test_with_dwarf_and_run_command(self):
"""Test data formatter commands."""

View File

@ -20,7 +20,7 @@ class StdStringDataFormatterTestCase(TestBase):
self.buildDsym()
self.data_formatter_commands()
@skipOnLinux # No standard locations for libc++ on Linux, so skip for now
@skipIfLinux # No standard locations for libc++ on Linux, so skip for now
@dwarf_test
def test_with_dwarf_and_run_command(self):
"""Test data formatter commands."""

View File

@ -31,7 +31,7 @@ class StdVBoolDataFormatterTestCase(TestBase):
# Find the line number to break at.
self.line = line_number('main.cpp', '// Set break point at this line.')
@expectedFailureGcc # PR-15301: lldb does not print the correct sizes of STL containers when building with GCC
@expectedFailureGcc # llvm.org/pr15301: lldb does not print the correct sizes of STL containers when building with GCC
def data_formatter_commands(self):
"""Test that that file and class static variables display correctly."""
self.runCmd("file a.out", CURRENT_EXECUTABLE_SET)

View File

@ -19,7 +19,7 @@ class DeadStripTestCase(TestBase):
self.buildDsym()
self.dead_strip()
@skipOnLinux # The -dead_strip linker option isn't supported on Linux versions of ld.
@skipIfLinux # The -dead_strip linker option isn't supported on Linux versions of ld.
@dwarf_test
def test_with_dwarf(self):
"""Test breakpoint works correctly with dead-code stripping."""

View File

@ -18,7 +18,7 @@ class ConvenienceVariablesCase(TestBase):
self.convenience_variables()
@dwarf_test
@skipOnLinux # llvm.org/pr14637: this test case fails sometimes because the input prompt "(lldb)" is missing
@skipIfLinux # llvm.org/pr14637: this test case fails sometimes because the input prompt "(lldb)" is missing
def test_with_dwarf_and_run_commands(self):
"""Test convenience variables lldb.debugger, lldb.target, lldb.process, lldb.thread, and lldb.frame."""
self.buildDwarf()

View File

@ -23,7 +23,7 @@ class ExprDoesntDeadlockTestCase(TestBase):
self.expr_doesnt_deadlock()
@dwarf_test
@skipOnLinux # PR-15258: disabled due to assertion failure in ProcessMonitor::GetCrashReasonForSIGSEGV:
@skipIfLinux # llvm.org/pr15258: disabled due to assertion failure in ProcessMonitor::GetCrashReasonForSIGSEGV:
def test_with_dwarf_and_run_command(self):
"""Test that expr will time out and allow other threads to run if it blocks."""
self.buildDwarf()

View File

@ -65,7 +65,7 @@ class CrashingInferiorTestCase(TestBase):
self.buildDsym()
self.inferior_crashing_step_after_break()
@expectedFailureLinux # due to bugzilla 15988 -- step over misbehaves after crash
@expectedFailureLinux # due to llvm.org/pr15988 -- step over misbehaves after crash
def test_inferior_crashing_step_after_break_dwarf(self):
"""Test that lldb functions correctly after stepping through a crash."""
self.buildDwarf()
@ -77,7 +77,7 @@ class CrashingInferiorTestCase(TestBase):
self.buildDsym()
self.inferior_crashing_expr_step_expr()
@expectedFailureLinux # due to bugzilla 15989 -- expression fails after crash and step
@expectedFailureLinux # due to llvm.org/pr15989 -- expression fails after crash and step
def test_inferior_crashing_expr_step_and_expr_dwarf(self):
"""Test that lldb expressions work before and after stepping after a crash."""
self.buildDwarf()

View File

@ -25,7 +25,7 @@ class LoadUnloadTestCase(TestBase):
self.line_d_function = line_number('d.c',
'// Find this line number within d_dunction().')
@skipOnLinux # bugzilla 14424 - missing linux Makefiles/testcase support
@skipIfLinux # llvm.org/pr14424 - missing linux Makefiles/testcase support
def test_modules_search_paths(self):
"""Test target modules list after loading a different copy of the library libd.dylib, and verifies that it works with 'target modules search-paths add'."""
@ -78,7 +78,7 @@ class LoadUnloadTestCase(TestBase):
self.expect("target modules list", "LLDB successfully locates the relocated dynamic library",
substrs = [new_dylib])
@skipOnLinux # bugzilla 14424 - missing linux Makefiles/testcase support
@skipIfLinux # llvm.org/pr14424 - missing linux Makefiles/testcase support
def test_dyld_library_path(self):
"""Test DYLD_LIBRARY_PATH after moving libd.dylib, which defines d_function, somewhere else."""
@ -132,7 +132,7 @@ class LoadUnloadTestCase(TestBase):
self.expect("target modules list",
substrs = [special_dir, os.path.basename(new_dylib)])
@skipOnLinux # bugzilla 14424 - missing linux Makefiles/testcase support
@skipIfLinux # llvm.org/pr14424 - missing linux Makefiles/testcase support
def test_lldb_process_load_and_unload_commands(self):
"""Test that lldb process load/unload command work correctly."""
@ -179,7 +179,7 @@ class LoadUnloadTestCase(TestBase):
self.runCmd("process continue")
@skipOnLinux # bugzilla 14424 - missing linux Makefiles/testcase support
@skipIfLinux # llvm.org/pr14424 - missing linux Makefiles/testcase support
def test_load_unload(self):
"""Test breakpoint by name works correctly with dlopen'ing."""
@ -219,7 +219,7 @@ class LoadUnloadTestCase(TestBase):
self.expect("breakpoint list -f", BREAKPOINT_HIT_ONCE,
substrs = [' resolved, hit count = 2'])
@skipOnLinux # bugzilla 14424 - missing linux Makefiles/testcase support
@skipIfLinux # llvm.org/pr14424 - missing linux Makefiles/testcase support
def test_step_over_load (self):
"""Test stepping over code that loads a shared library works correctly."""

View File

@ -27,7 +27,7 @@ class PlatformCommandTestCase(TestBase):
self.expect("platform process info", error=True,
substrs = ['one or more process id(s) must be specified'])
@expectedFailureLinux # due to bugzilla 14806 -- "platform status" prints more information on Mac OS X than on Linux
@expectedFailureLinux # due to llvm.org/pr14806 -- "platform status" prints more information on Mac OS X than on Linux
def test_status(self):
self.expect("platform status",
substrs = ['Platform', 'Triple', 'OS Version', 'Kernel', 'Hostname'])

View File

@ -45,7 +45,7 @@ class RegisterCommandsTestCase(TestBase):
self.buildDefault()
self.convenience_registers()
@skipOnLinux # Expression evaluation fails after attach by pid
@skipIfLinux # Expression evaluation fails after attach by pid
def test_convenience_registers_with_process_attach(self):
"""Test convenience registers after a 'process attach'."""
if not self.getArchitecture() in ['x86_64']:

View File

@ -23,7 +23,7 @@ class SingleQuoteInCommandLineTestCase(TestBase):
except:
pass
@skipOnLinux # llvm.org/pr14637: this test case fails sometimes because the input prompt "(lldb)" is missing
@skipIfLinux # llvm.org/pr14637: this test case fails sometimes because the input prompt "(lldb)" is missing
def test_lldb_invocation_with_single_quote_in_filename(self):
"""Test that 'lldb my_file_name' works where my_file_name is a string with a single quote char in it."""
self.buildDefault()

View File

@ -19,7 +19,7 @@ class StopHookMechanismTestCase(TestBase):
self.buildDsym()
self.stop_hook_firing()
@skipOnLinux # PR-15037: stop-hooks sometimes fail to fire on Linux (disabled to avoid needless noise)
@skipIfLinux # llvm.org/pr15037: stop-hooks sometimes fail to fire on Linux (disabled to avoid needless noise)
@dwarf_test
def test_with_dwarf(self):
"""Test the stop-hook mechanism."""

View File

@ -21,7 +21,7 @@ class StopHookForMultipleThreadsTestCase(TestBase):
self.stop_hook_multiple_threads()
@dwarf_test
@skipOnLinux # due to bugzilla 14323
@skipIfLinux # due to llvm.org/pr14323
def test_stop_hook_multiple_threads_with_dwarf(self):
"""Test that lldb stop-hook works for multiple threads."""
self.buildDwarf(dictionary=self.d)

View File

@ -53,14 +53,14 @@ class StopThreadsTestCase(TestBase):
@unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin")
@dsym_test
@unittest2.expectedFailure("PR-15824") # thread states not properly maintained
@unittest2.expectedFailure("llvm.org/pr15824") # thread states not properly maintained
def test_process_interrupt_with_dsym(self):
"""Test process interrupt."""
self.buildDsym()
self.process_interrupt_test()
@dwarf_test
@unittest2.expectedFailure("PR-15824") # thread states not properly maintained
@unittest2.expectedFailure("llvm.org/pr15824") # thread states not properly maintained
def test_process_interrupt_with_dwarf(self):
"""Test process interrupt."""
self.buildDwarf()
@ -68,14 +68,14 @@ class StopThreadsTestCase(TestBase):
@unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin")
@dsym_test
@unittest2.expectedFailure("PR-15824") # thread states not properly maintained
@unittest2.expectedFailure("llvm.org/pr15824") # thread states not properly maintained
def test_process_state_with_dsym(self):
"""Test thread states (comprehensive)."""
self.buildDsym()
self.thread_states_test()
@dwarf_test
@unittest2.expectedFailure("PR-15824") # thread states not properly maintained
@unittest2.expectedFailure("llvm.org/pr15824") # thread states not properly maintained
def test_process_state_with_dwarf(self):
"""Test thread states (comprehensive)."""
self.buildDwarf()

View File

@ -21,7 +21,7 @@ class WatchpointForMultipleThreadsTestCase(TestBase):
self.setTearDownCleanup(dictionary=self.d)
self.hello_multiple_threads()
@skipOnLinux # bugzilla 14323 - skip due to incomplete multi-threaded debug support
@skipIfLinux # llvm.org/pr14323 - skip due to incomplete multi-threaded debug support
@dwarf_test
def test_watchpoint_multiple_threads_with_dwarf(self):
"""Test that lldb watchpoint works for multiple threads."""
@ -37,7 +37,7 @@ class WatchpointForMultipleThreadsTestCase(TestBase):
self.setTearDownCleanup(dictionary=self.d)
self.hello_multiple_threads_wp_set_and_then_delete()
@skipOnLinux # bugzilla 14323 - skip due to incomplete multi-threaded debug support
@skipIfLinux # llvm.org/pr14323 - skip due to incomplete multi-threaded debug support
@dwarf_test
def test_watchpoint_multiple_threads_wp_set_and_then_delete_with_dwarf(self):
"""Test that lldb watchpoint works for multiple threads, and after the watchpoint is deleted, the watchpoint event should no longer fires."""

View File

@ -17,7 +17,7 @@ class ConstVariableTestCase(TestBase):
self.buildDsym()
self.const_variable()
@skipOnLinux # This test works with gcc, but fails with newer version of clang on Linux due to a clang issue. Bug number TDB.
@skipIfLinux # This test works with gcc, but fails with newer version of clang on Linux due to a clang issue. Bug number TDB.
@dwarf_test
@unittest2.expectedFailure(13314878)
def test_with_dwarf_and_run_command(self):

View File

@ -21,7 +21,7 @@ class TestObjCStepping(TestBase):
self.buildDsym()
self.step_over_stepping()
@expectedFailureLinux # bugzilla 14437
@expectedFailureLinux # llvm.org/pr14437
@python_api_test
@dwarf_test
def test_with_dwarf_and_python_api(self):

View File

@ -19,7 +19,7 @@ class StaticVariableTestCase(TestBase):
self.buildDsym()
self.static_variable_commands()
@expectedFailureLinux # PR-15261: lldb on Linux does not display the size of (class or file)static arrays
@expectedFailureLinux # llvm.org/pr15261: lldb on Linux does not display the size of (class or file)static arrays
@dwarf_test
def test_with_dwarf_and_run_command(self):
"""Test that file and class static variables display correctly."""

View File

@ -20,7 +20,7 @@ class IterateFrameAndDisassembleTestCase(TestBase):
self.disassemble_call_stack()
@dwarf_test
@expectedFailureLinux # due to bugzilla 14540
@expectedFailureLinux # due to llvm.org/pr14540
def test_with_dwarf_and_run_command(self):
"""Disassemble each call frame when stopped on C's constructor."""
self.buildDwarf()
@ -36,7 +36,7 @@ class IterateFrameAndDisassembleTestCase(TestBase):
@python_api_test
@dwarf_test
@expectedFailureLinux # due to bugzilla 14540
@expectedFailureLinux # due to llvm.org/pr14540
def test_with_dwarf_and_python_api(self):
"""Disassemble each call frame when stopped on C's constructor."""
self.buildDwarf()

View File

@ -21,7 +21,7 @@ class NamespaceTestCase(TestBase):
self.namespace_variable_commands()
# rdar://problem/8668674
@expectedFailureGcc # PR-15302: lldb does not print 'anonymous namespace' when the inferior is built with GCC (4.7)
@expectedFailureGcc # llvm.org/pr15302: lldb does not print 'anonymous namespace' when the inferior is built with GCC (4.7)
@dwarf_test
def test_with_dwarf_and_run_command(self):
"""Test that anonymous and named namespace variables display correctly."""

View File

@ -21,7 +21,7 @@ class BuiltinTrapTestCase(TestBase):
self.builtin_trap_unwind()
@dwarf_test
@expectedFailureGcc # PR-15936: LLDB is omits a function that contains an
@expectedFailureGcc # llvm.org/pr15936: LLDB is omits a function that contains an
# illegal opcode from backtraces. This
# failure is GCC 4.6 specific.
def test_with_dwarf_and_run_command(self):

View File

@ -585,10 +585,10 @@ def expectedFailureDarwin(bugnumber=None):
return wrapper
return expectedFailureDarwin_impl
def skipOnLinux(func):
def skipIfLinux(func):
"""Decorate the item to skip tests that should be skipped on Linux."""
if isinstance(func, type) and issubclass(func, unittest2.TestCase):
raise Exception("@skipOnLinux can only be used to decorate a test method")
raise Exception("@skipIfLinux can only be used to decorate a test method")
@wraps(func)
def wrapper(*args, **kwargs):
from unittest2 import case

View File

@ -18,7 +18,7 @@ class RegistersIteratorTestCase(TestBase):
# Find the line number to break inside main().
self.line1 = line_number('main.cpp', '// Set break point at this line.')
@expectedFailureLinux # bugzilla 14600 - Exception state registers not supported on Linux
@expectedFailureLinux # llvm.org/pr14600 - Exception state registers not supported on Linux
@python_api_test
def test_iter_registers(self):
"""Test iterator works correctly for lldbutil.iter_registers()."""

View File

@ -18,7 +18,7 @@ class ThreadsStackTracesTestCase(TestBase):
# Find the line number to break inside main().
self.line = line_number('main.cpp', '// Set break point at this line.')
@expectedFailureLinux # bugzilla 14323
@expectedFailureLinux # llvm.org/pr14323
@python_api_test
def test_stack_traces(self):
"""Test SBprocess and SBThread APIs with printing of the stack traces."""

View File

@ -235,7 +235,7 @@ class SBDataAPICase(TestBase):
self.assert_data(data.GetUnsignedInt8, offset, 68)
offset += 1
# check the new API calls introduced per LLVM bugzilla enhancement request
# check the new API calls introduced per LLVM llvm.org/prenhancement request
# 11619 (Allow creating SBData values from arrays or primitives in Python)
hello_str = "hello!"

View File

@ -74,7 +74,7 @@ class ThreadAPITestCase(TestBase):
self.setTearDownCleanup(dictionary=d)
self.step_out_of_malloc_into_function_b(self.exe_name)
@expectedFailureLinux # bugzilla 14416
@expectedFailureLinux # llvm.org/pr14416
@python_api_test
@dwarf_test
def test_step_out_of_malloc_into_function_b_with_dwarf(self):

View File

@ -41,7 +41,7 @@ class ChangeValueAPITestCase(TestBase):
self.check_line = line_number('main.c', '// Stop here and check values')
self.end_line = line_number ('main.c', '// Set a breakpoint here at the end')
@skipIfGcc # PR-15039: If GCC is the test compiler, stdout is not available via lldb.SBProcess.GetSTDOUT()
@skipIfGcc # llvm.org/pr15039: If GCC is the test compiler, stdout is not available via lldb.SBProcess.GetSTDOUT()
def change_value_api(self, exe_name):
"""Exercise some SBValue APIs."""
exe = os.path.join(os.getcwd(), exe_name)

View File

@ -30,7 +30,7 @@ class SetWatchlocationAPITestCase(TestBase):
self.buildDsym()
self.do_set_watchlocation()
@expectedFailureLinux # bugzilla 14416
@expectedFailureLinux # llvm.org/pr14416
@python_api_test
@dwarf_test
def test_watch_location_with_dwarf(self):

View File

@ -30,7 +30,7 @@ class TargetWatchAddressAPITestCase(TestBase):
self.buildDsym()
self.do_set_watchaddress()
@expectedFailureLinux # bugzilla 14416
@expectedFailureLinux # llvm.org/pr14416
@python_api_test
@dwarf_test
def test_watch_address_with_dwarf(self):