From e5ba87b6bb682d0315743242f154b0900db02cb0 Mon Sep 17 00:00:00 2001 From: "Ariel J. Bernal" Date: Tue, 24 Sep 2013 15:41:30 +0000 Subject: [PATCH] Clean up timing command line option. Use getNumOccurrences instead of usina a default constant string. llvm-svn: 191308 --- clang-tools-extra/clang-modernize/tool/ClangModernize.cpp | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/clang-tools-extra/clang-modernize/tool/ClangModernize.cpp b/clang-tools-extra/clang-modernize/tool/ClangModernize.cpp index 49f28d3d80b1..a824b0902595 100644 --- a/clang-tools-extra/clang-modernize/tool/ClangModernize.cpp +++ b/clang-tools-extra/clang-modernize/tool/ClangModernize.cpp @@ -93,11 +93,10 @@ static cl::opt SummaryMode("summary", cl::desc("Print transform summary"), cl::init(false)); -const char NoTiming[] = "no_timing"; static cl::opt TimingDirectoryName( "perf", cl::desc("Capture performance data and output to specified " "directory. Default: ./migrate_perf"), - cl::init(NoTiming), cl::ValueOptional, cl::value_desc("directory name")); + cl::ValueOptional, cl::value_desc("directory name")); static cl::opt IncludePaths("include", @@ -384,9 +383,8 @@ int main(int argc, const char **argv) { return 1; } - // Since ExecutionTimeDirectoryName could be an empty string we compare - // against the default value when the command line option is not specified. - GlobalOptions.EnableTiming = (TimingDirectoryName != NoTiming); + // Enable timming. + GlobalOptions.EnableTiming = TimingDirectoryName.getNumOccurrences() > 0; // Check the reformatting style option bool CmdSwitchError = false;