replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Eliminate this ugly hack. This was put back in when replaceAllUsesOf used 

a different algorithm that was extremely inefficient for instructions with
many operands.

This reduces the time of this code snippet from .23s for 176.gcc to 0.03s
in a debug build, which speeds up total llvm-dis time just barely.

It's more of a code cleanup than a speedup.

llvm-svn: 18685
This commit is contained in:
Chris Lattner 2004-12-09 04:51:50 +00:00
parent 346ee4c9fb
commit e44907012a
1 changed files with 6 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
llvm/lib/Bytecode/Reader/Reader.cpp
View File

@ -30,6 +30,8 @@
#include <algorithm>
using namespace llvm;
#include "llvm/Support/Timer.h"
namespace {
/// @brief A class for maintaining the slot number definition
@ -1690,39 +1692,13 @@ void BytecodeReader::ParseFunctionBody(Function* F) {
// Resolve forward references. Replace any uses of a forward reference value
// with the real value.
// replaceAllUsesWith is very inefficient for instructions which have a LARGE
// number of operands. PHI nodes often have forward references, and can also
// often have a very large number of operands.
//
// FIXME: REEVALUATE. replaceAllUsesWith is _much_ faster now, and this code
// should be simplified back to using it!
//
std::map<Value*, Value*> ForwardRefMapping;
for (std::map<std::pair<unsigned,unsigned>, Value*>::iterator
I = ForwardReferences.begin(), E = ForwardReferences.end();
I != E; ++I)
ForwardRefMapping[I->second] = getValue(I->first.first, I->first.second,
false);
for (Function::iterator BB = F->begin(), E = F->end(); BB != E; ++BB)
for (BasicBlock::iterator I = BB->begin(), E = BB->end(); I != E; ++I)
for (unsigned i = 0, e = I->getNumOperands(); i != e; ++i)
if (Value* V = I->getOperand(i))
if (Argument *A = dyn_cast<Argument>(V)) {
std::map<Value*, Value*>::iterator It = ForwardRefMapping.find(A);
if (It != ForwardRefMapping.end()) I->setOperand(i, It->second);
}
while (!ForwardReferences.empty()) {
std::map<std::pair<unsigned,unsigned>, Value*>::iterator I =
ForwardReferences.begin();
std::map<std::pair<unsigned,unsigned>, Value*>::iterator
I = ForwardReferences.begin();
Value *V = getValue(I->first.first, I->first.second, false);
Value *PlaceHolder = I->second;
PlaceHolder->replaceAllUsesWith(V);
ForwardReferences.erase(I);
// Now that all the uses are gone, delete the placeholder...
// If we couldn't find a def (error case), then leak a little
// memory, because otherwise we can't remove all uses!
delete PlaceHolder;
}