From e3c48deff52bcc3288e03926478d19e210c6e476 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Mon, 1 Nov 2010 23:57:23 +0000 Subject: [PATCH] fix computation of ambiguous instructions to not ignore the mnemonic. FWIW, X86 has 254 ambiguous instructions. llvm-svn: 117979 --- llvm/utils/TableGen/AsmMatcherEmitter.cpp | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/llvm/utils/TableGen/AsmMatcherEmitter.cpp b/llvm/utils/TableGen/AsmMatcherEmitter.cpp index 7f653a3f7d9c..532a7b5f1757 100644 --- a/llvm/utils/TableGen/AsmMatcherEmitter.cpp +++ b/llvm/utils/TableGen/AsmMatcherEmitter.cpp @@ -411,6 +411,10 @@ struct MatchableInfo { /// ambiguously match the same set of operands as \arg RHS (without being a /// strictly superior match). bool CouldMatchAmiguouslyWith(const MatchableInfo &RHS) { + // The primary comparator is the instruction mnemonic. + if (Tokens[0] != RHS.Tokens[0]) + return false; + // The number of operands is unambiguous. if (Operands.size() != RHS.Operands.size()) return false; @@ -849,8 +853,8 @@ BuildRegisterClasses(SmallPtrSet &SingletonRegisters) { } void AsmMatcherInfo::BuildOperandClasses() { - std::vector AsmOperands; - AsmOperands = Records.getAllDerivedDefinitions("AsmOperandClass"); + std::vector AsmOperands = + Records.getAllDerivedDefinitions("AsmOperandClass"); // Pre-populate AsmOperandClasses map. for (std::vector::iterator it = AsmOperands.begin(), @@ -1127,7 +1131,7 @@ static void EmitConvertToMCInst(CodeGenTarget &Target, } } - std::sort(MIOperandList.begin(), MIOperandList.end()); + array_pod_sort(MIOperandList.begin(), MIOperandList.end()); // Compute the total number of operands. unsigned NumMIOperands = 0;