replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

IRgen/CGValue: Add alignment to LValue, and use that alignment when generating lvalue load/stores. 

llvm-svn: 111710
This commit is contained in:
Daniel Dunbar 2010-08-21 02:39:23 +00:00
parent 42ef669d81
commit e3b8dd433c
2 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
clang/lib/CodeGen/CGExpr.cpp
View File

@ -635,11 +635,9 @@ RValue CodeGenFunction::EmitLoadOfLValue(LValue LV, QualType ExprType) {
// Simple scalar l-value.
//
// FIXME: We shouldn't have to use isSingleValueType here.
//
// FIXME: Pass alignment!
if (EltTy->isSingleValueType())
return RValue::get(EmitLoadOfScalar(Ptr, LV.isVolatileQualified(),
/*Alignment=*/0, ExprType));
LV.getAlignment(), ExprType));
assert(ExprType->isFunctionType() && "Unknown scalar value");
return RValue::get(Ptr);
@ -849,9 +847,8 @@ void CodeGenFunction::EmitStoreThroughLValue(RValue Src, LValue Dst,
}
assert(Src.isScalar() && "Can't emit an agg store with this method");
// FIXME: Pass alignment.
EmitStoreOfScalar(Src.getScalarVal(), Dst.getAddress(),
Dst.isVolatileQualified(), /*Alignment=*/0, Ty);
Dst.isVolatileQualified(), Dst.getAlignment(), Ty);
}
void CodeGenFunction::EmitStoreThroughBitfieldLValue(RValue Src, LValue Dst,

17
clang/lib/CodeGen/CGValue.h
View File

@ -136,6 +136,9 @@ class LValue {
// 'const' is unused here
Qualifiers Quals;
/// The alignment to use when accessing this lvalue.
unsigned char Alignment;
// objective-c's ivar
bool Ivar:1;
@ -154,11 +157,12 @@ class LValue {
Expr *BaseIvarExp;
private:
void Initialize(Qualifiers Quals) {
void Initialize(Qualifiers Quals, unsigned Alignment = 0) {
this->Quals = Quals;
this->Alignment = Alignment;
assert(this->Alignment == Alignment && "Alignment exceeds allowed max!");
// FIXME: Convenient place to set objc flags to 0. This should really be
// done in a user-defined constructor instead.
// Initialize Objective-C flags.
this->Ivar = this->ObjIsArray = this->NonGC = this->GlobalObjCRef = false;
this->ThreadLocalRef = false;
this->BaseIvarExp = 0;
@ -191,6 +195,8 @@ public:
unsigned getAddressSpace() const { return Quals.getAddressSpace(); }
unsigned getAlignment() const { return Alignment; }
static void SetObjCIvar(LValue& R, bool iValue) {
R.Ivar = iValue;
}
@ -243,11 +249,12 @@ public:
return KVCRefExpr;
}
static LValue MakeAddr(llvm::Value *V, Qualifiers Quals) {
static LValue MakeAddr(llvm::Value *V, Qualifiers Quals,
unsigned Alignment = 0) {
LValue R;
R.LVType = Simple;
R.V = V;
R.Initialize(Quals);
R.Initialize(Quals, Alignment);
return R;
}