From e1c01e4e2b5e524ae07d37a2d4816326f78a3124 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Sun, 18 Jan 2009 23:22:07 +0000 Subject: [PATCH] Make this a bit more explicit about which cases need the check. No functionality change. llvm-svn: 62474 --- llvm/lib/Transforms/Utils/SimplifyCFG.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/llvm/lib/Transforms/Utils/SimplifyCFG.cpp b/llvm/lib/Transforms/Utils/SimplifyCFG.cpp index 366021e6480e..1a0b0b4b66d1 100644 --- a/llvm/lib/Transforms/Utils/SimplifyCFG.cpp +++ b/llvm/lib/Transforms/Utils/SimplifyCFG.cpp @@ -969,14 +969,18 @@ static bool SpeculativelyExecuteBB(BranchInst *BI, BasicBlock *BB1) { default: return false; // Not safe / profitable to hoist. case Instruction::Add: case Instruction::Sub: + // FP arithmetic might trap. Not worth doing for vector ops. + if (I->getType()->isFloatingPoint() || isa(I->getType())) + return false; + break; case Instruction::And: case Instruction::Or: case Instruction::Xor: case Instruction::Shl: case Instruction::LShr: case Instruction::AShr: - if (!I->getOperand(0)->getType()->isInteger()) - // FP arithmetic might trap. Not worth doing for vector ops. + // Don't mess with vector operations. + if (isa(I->getType())) return false; break; // These are all cheap and non-trapping instructions. }