replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Avoid redundant select node in early if-conversion pass 

llvm-svn: 240072
This commit is contained in:
Yi Jiang 2015-06-18 22:34:09 +00:00
parent 67d492a544
commit e0b3499db7
2 changed files with 54 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
llvm/lib/CodeGen/EarlyIfConversion.cpp
View File

@ -479,11 +479,20 @@ void SSAIfConv::rewritePHIOperands() {
// Convert all PHIs to select instructions inserted before FirstTerm.
for (unsigned i = 0, e = PHIs.size(); i != e; ++i) {
PHIInfo &PI = PHIs[i];
unsigned DstReg = 0;
DEBUG(dbgs() << "If-converting " << *PI.PHI);
unsigned PHIDst = PI.PHI->getOperand(0).getReg();
unsigned DstReg = MRI->createVirtualRegister(MRI->getRegClass(PHIDst));
TII->insertSelect(*Head, FirstTerm, HeadDL, DstReg, Cond, PI.TReg, PI.FReg);
DEBUG(dbgs() << " --> " << *std::prev(FirstTerm));
if (PI.TReg == PI.FReg) {
// We do not need the select instruction if both incoming values are
// equal.
DstReg = PI.TReg;
} else {
unsigned PHIDst = PI.PHI->getOperand(0).getReg();
DstReg = MRI->createVirtualRegister(MRI->getRegClass(PHIDst));
TII->insertSelect(*Head, FirstTerm, HeadDL,
DstReg, Cond, PI.TReg, PI.FReg);
DEBUG(dbgs() << " --> " << *std::prev(FirstTerm));
}
// Rewrite PHI operands TPred -> (DstReg, Head), remove FPred.
for (unsigned i = PI.PHI->getNumOperands(); i != 1; i -= 2) {

41
llvm/test/CodeGen/AArch64/ifcvt-select.ll Normal file
View File

@ -0,0 +1,41 @@
; RUN: llc -mtriple=arm64-apple-ios -mcpu=cyclone < %s | FileCheck %s
; Do not generate redundant select in early if-converstion pass.
define i32 @foo(i32 %a, i32 %b) {
entry:
;CHECK-LABEL: foo:
;CHECK: csinc
;CHECK-NOT: csel
%sub = sub nsw i32 %b, %a
%cmp10 = icmp sgt i32 %a, 0
br i1 %cmp10, label %while.body.lr.ph, label %while.end
while.body.lr.ph:
br label %while.body
while.body:
%j.012 = phi i32 [ %sub, %while.body.lr.ph ], [ %inc, %if.then ], [ %inc, %if.else ]
%i.011 = phi i32 [ %a, %while.body.lr.ph ], [ %inc2, %if.then ], [ %dec, %if.else ]
%cmp1 = icmp slt i32 %i.011, %j.012
br i1 %cmp1, label %while.end, label %while.cond
while.cond:
%inc = add nsw i32 %j.012, 5
%cmp2 = icmp slt i32 %inc, %b
br i1 %cmp2, label %if.then, label %if.else
if.then:
%inc2 = add nsw i32 %i.011, 1
br label %while.body
if.else:
%dec = add nsw i32 %i.011, -1
br label %while.body
while.end:
%j.0.lcssa = phi i32 [ %j.012, %while.body ], [ %sub, %entry ]
%i.0.lcssa = phi i32 [ %i.011, %while.body ], [ %a, %entry ]
%add = add nsw i32 %j.0.lcssa, %i.0.lcssa
ret i32 %add
}