replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

"frame variable" and "target variable" shouldn't allow us to get the address of bitfields. 

"frame variable" and "target variable" are trying to emulate the expression parser when doing things like:

(lldb) frame variable &my_struct.my_bitfield

And since the expression parser doesn't allow this, we shouldn't allow "frame variable" or "target variable" to succeed.

<rdar://problem/27208607> 

llvm-svn: 274703
This commit is contained in:
Greg Clayton 2016-07-06 23:16:24 +00:00
parent 5e4bd2e7c4
commit df62e731ea
1 changed files with 18 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
lldb/source/Core/ValueObject.cpp
View File

@ -834,20 +834,20 @@ ValueObject::CreateChildAtIndex (size_t idx, bool synthetic_array_member, int32_
ExecutionContext exe_ctx (GetExecutionContextRef());
child_compiler_type = GetCompilerType().GetChildCompilerTypeAtIndex (&exe_ctx,
idx,
transparent_pointers,
omit_empty_base_classes,
ignore_array_bounds,
child_name_str,
child_byte_size,
child_byte_offset,
child_bitfield_bit_size,
child_bitfield_bit_offset,
child_is_base_class,
child_is_deref_of_parent,
this,
language_flags);
child_compiler_type = GetCompilerType().GetChildCompilerTypeAtIndex(&exe_ctx,
idx,
transparent_pointers,
omit_empty_base_classes,
ignore_array_bounds,
child_name_str,
child_byte_size,
child_byte_offset,
child_bitfield_bit_size,
child_bitfield_bit_offset,
child_is_base_class,
child_is_deref_of_parent,
this,
language_flags);
if (child_compiler_type)
{
if (synthetic_index)
@ -1789,6 +1789,10 @@ ValueObject::DumpPrintableRepresentation(Stream& s,
addr_t
ValueObject::GetAddressOf (bool scalar_is_load_address, AddressType *address_type)
{
// Can't take address of a bitfield
if (IsBitfield())
return LLDB_INVALID_ADDRESS;
if (!UpdateValueIfNeeded(false))
return LLDB_INVALID_ADDRESS;