replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Shifting into the sign bit is UB as discussed on IRC. Explicitly use the 

BitWord type for the constants to avoid this.

llvm-svn: 205257
This commit is contained in:
Joerg Sonnenberger 2014-03-31 22:53:57 +00:00
parent ae2f0bbcf1
commit deb1e4adc1
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
llvm/include/llvm/ADT/BitVector.h
View File

@ -58,14 +58,14 @@ public:
reference& operator=(bool t) { reference& operator=(bool t) {
if (t) if (t)
*WordRef |= 1L << BitPos; *WordRef |= BitWord(1) << BitPos;
else else
*WordRef &= ~(1L << BitPos); *WordRef &= ~(BitWord(1) << BitPos);
return *this; return *this;
} }
operator bool() const { operator bool() const {
return ((*WordRef) & (1L << BitPos)) ? true : false; return ((*WordRef) & (BitWord(1) << BitPos)) ? true : false;
} }
}; };
@ -238,7 +238,7 @@ public:
} }
BitVector &set(unsigned Idx) { BitVector &set(unsigned Idx) {
Bits[Idx / BITWORD_SIZE] |= 1L << (Idx % BITWORD_SIZE); Bits[Idx / BITWORD_SIZE] |= BitWord(1) << (Idx % BITWORD_SIZE);
return *this; return *this;
} }
@ -277,7 +277,7 @@ public:
} }
BitVector &reset(unsigned Idx) { BitVector &reset(unsigned Idx) {
Bits[Idx / BITWORD_SIZE] &= ~(1L << (Idx % BITWORD_SIZE)); Bits[Idx / BITWORD_SIZE] &= ~(BitWord(1) << (Idx % BITWORD_SIZE));
return *this; return *this;
} }
@ -318,7 +318,7 @@ public:
} }
BitVector &flip(unsigned Idx) { BitVector &flip(unsigned Idx) {
Bits[Idx / BITWORD_SIZE] ^= 1L << (Idx % BITWORD_SIZE); Bits[Idx / BITWORD_SIZE] ^= BitWord(1) << (Idx % BITWORD_SIZE);
return *this; return *this;
} }
@ -330,7 +330,7 @@ public:
bool operator[](unsigned Idx) const { bool operator[](unsigned Idx) const {
assert (Idx < Size && "Out-of-bounds Bit access."); assert (Idx < Size && "Out-of-bounds Bit access.");
BitWord Mask = 1L << (Idx % BITWORD_SIZE); BitWord Mask = BitWord(1) << (Idx % BITWORD_SIZE);
return (Bits[Idx / BITWORD_SIZE] & Mask) != 0; return (Bits[Idx / BITWORD_SIZE] & Mask) != 0;
} }