From dd870f6929ee0b1dfb5fd000c7b826a1bd2d2571 Mon Sep 17 00:00:00 2001 From: Reid Kleckner Date: Thu, 7 Nov 2019 10:37:04 -0800 Subject: [PATCH] Fix warning about unused std::unique result, erase shifted elements This is actually a functional change. I haven't added any new test coverage. I'm just trying to fix the warning and hoping for the best. --- .../clang/Serialization/ContinuousRangeMap.h | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/clang/include/clang/Serialization/ContinuousRangeMap.h b/clang/include/clang/Serialization/ContinuousRangeMap.h index 0c05537dd108..c2665c097416 100644 --- a/clang/include/clang/Serialization/ContinuousRangeMap.h +++ b/clang/include/clang/Serialization/ContinuousRangeMap.h @@ -118,14 +118,17 @@ public: ~Builder() { llvm::sort(Self.Rep, Compare()); - std::unique(Self.Rep.begin(), Self.Rep.end(), - [](const_reference A, const_reference B) { - // FIXME: we should not allow any duplicate keys, but there are a lot of - // duplicate 0 -> 0 mappings to remove first. - assert((A == B || A.first != B.first) && - "ContinuousRangeMap::Builder given non-unique keys"); - return A == B; - }); + Self.Rep.erase( + std::unique( + Self.Rep.begin(), Self.Rep.end(), + [](const_reference A, const_reference B) { + // FIXME: we should not allow any duplicate keys, but there are + // a lot of duplicate 0 -> 0 mappings to remove first. + assert((A == B || A.first != B.first) && + "ContinuousRangeMap::Builder given non-unique keys"); + return A == B; + }), + Self.Rep.end()); } void insert(const value_type &Val) {