replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Don't ICE when messaging on 'super' receiver when class 

of category implementation is undeclared. Issue error instead.

llvm-svn: 61882
This commit is contained in:
Fariborz Jahanian 2009-01-07 21:01:41 +00:00
parent 475831bd6e
commit dd2d75bb52
3 changed files with 21 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang/include/clang/Basic/DiagnosticKinds.def
View File

@ -536,6 +536,8 @@ DIAG(error_bad_receiver_type, ERROR,
"bad receiver type %0")
DIAG(error_no_super_class, ERROR,
"no super class declared in @interface for %0")
DIAG(error_no_super_class_message, ERROR,
"no @interface declaration found in class messaging of %0")
DIAG(error_missing_property_context, ERROR,
"missing context for property implementation declaration")
DIAG(error_bad_property_context, ERROR,

9
clang/lib/Sema/SemaExprObjC.cpp
View File

@ -190,10 +190,13 @@ Sema::ExprResult Sema::ActOnClassMessage(
if (receiverName->isStr("super")) {
if (getCurMethodDecl()) {
isSuper = true;
ClassDecl = getCurMethodDecl()->getClassInterface()->getSuperClass();
ObjCInterfaceDecl *OID = getCurMethodDecl()->getClassInterface();
if (!OID)
return Diag(lbrac, diag::error_no_super_class_message)
<< getCurMethodDecl()->getDeclName();
ClassDecl = OID->getSuperClass();
if (!ClassDecl)
return Diag(lbrac, diag::error_no_super_class)
<< getCurMethodDecl()->getClassInterface()->getDeclName();
return Diag(lbrac, diag::error_no_super_class) << OID->getDeclName();
if (getCurMethodDecl()->isInstance()) {
QualType superTy = Context.getObjCInterfaceType(ClassDecl);
superTy = Context.getPointerType(superTy);

13
clang/test/SemaObjC/undef-class-messagin-error.m Normal file
View File

@ -0,0 +1,13 @@
// RUN: clang -fsyntax-only -verify %s
@interface _Child
+ (int) flashCache;
@end
@interface Child (Categ) // expected-error {{cannot find interface declaration for 'Child'}}
+ (int) flushCache2;
@end
@implementation Child (Categ) // expected-error {{cannot find interface declaration for 'Child'}}
+ (int) flushCache2 { [super flashCache]; } // expected-error {{no @interface declaration found in class messaging of 'flushCache2'}}
@end