From dc83a54567bef6da3b188fb4a3b72de3c4b99d00 Mon Sep 17 00:00:00 2001
From: Chris Lattner <sabre@nondot.org>
Date: Mon, 5 Jan 2009 18:27:50 +0000
Subject: [PATCH] reject PR3281:crash11.ll with: llvm-as: crash11.ll:2:27:
 function may not return return opaque type   "xw" = tail call opaque
 @608(label %31)                           ^

llvm-svn: 61722
---
 llvm/lib/AsmParser/LLParser.cpp | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/llvm/lib/AsmParser/LLParser.cpp b/llvm/lib/AsmParser/LLParser.cpp
index c13737aae525..a9f8e192d382 100644
--- a/llvm/lib/AsmParser/LLParser.cpp
+++ b/llvm/lib/AsmParser/LLParser.cpp
@@ -602,11 +602,17 @@ GlobalValue *LLParser::GetGlobalVal(unsigned ID, const Type *Ty, LocTy Loc) {
   
   // Otherwise, create a new forward reference for this value and remember it.
   GlobalValue *FwdVal;
-  if (const FunctionType *FT = dyn_cast<FunctionType>(PTy->getElementType()))
+  if (const FunctionType *FT = dyn_cast<FunctionType>(PTy->getElementType())) {
+    // Function types can return opaque but functions can't.
+    if (isa<OpaqueType>(FT->getReturnType())) {
+      Error(Loc, "function may not return return opaque type");
+      return 0;
+    }
     FwdVal = Function::Create(FT, GlobalValue::ExternalWeakLinkage, "", M);
-  else
+  } else {
     FwdVal = new GlobalVariable(PTy->getElementType(), false,
                                 GlobalValue::ExternalWeakLinkage, 0, "", M);
+  }
   
   ForwardRefValIDs[ID] = std::make_pair(FwdVal, Loc);
   return FwdVal;