replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[arcmt] Now that properties are strong by default, avoid adding redundant '(strong)' 

property attribute.

llvm-svn: 144078
This commit is contained in:
Argyrios Kyrtzidis 2011-11-08 05:56:11 +00:00
parent 3befb8cd8a
commit dbe077a89d
3 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
clang/lib/ARCMigrate/TransProperties.cpp
View File

@ -287,8 +287,10 @@ private:
void maybeAddStrongAttr(PropsTy &props, SourceLocation atLoc) const {
ObjCPropertyDecl::PropertyAttributeKind propAttrs = getPropertyAttrs(props);
if (!(propAttrs & ObjCPropertyDecl::OBJC_PR_readonly) ||
!hasAllIvarsBacked(props)) {
if (!(propAttrs & ObjCPropertyDecl::OBJC_PR_readonly))
return; // 'strong' by default.
if (!hasAllIvarsBacked(props)) {
addAttribute("strong", atLoc);
}

4
clang/test/ARCMT/GC.m
View File

@ -57,15 +57,17 @@ __attribute__((objc_arc_weak_reference_unavailable))
@interface I4Impl {
I4Impl *pds2;
I4Impl *pds3;
}
@property (assign) I4Impl *__weak pw1, *__weak pw2;
@property (assign) I4Impl *__strong ps;
@property (assign) I4Impl * pds;
@property (assign) I4Impl * pds2;
@property (readwrite) I4Impl * pds3;
@end
@implementation I4Impl
@synthesize pw1, pw2, ps, pds, pds2;
@synthesize pw1, pw2, ps, pds, pds2, pds3;
-(void)test1:(CFTypeRef *)cft {
id x = NSMakeCollectable(cft);

4
clang/test/ARCMT/GC.m.result
View File

@ -52,15 +52,17 @@ __attribute__((objc_arc_weak_reference_unavailable))
@interface I4Impl {
I4Impl *pds2;
I4Impl *pds3;
}
@property (weak) I4Impl * pw1, * pw2;
@property I4Impl * ps;
@property I4Impl * pds;
@property I4Impl * pds2;
@property (readwrite) I4Impl * pds3;
@end
@implementation I4Impl
@synthesize pw1, pw2, ps, pds, pds2;
@synthesize pw1, pw2, ps, pds, pds2, pds3;
-(void)test1:(CFTypeRef *)cft {
id x = CFBridgingRelease(cft);