replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[PECOFF] Replace magic numbers with offsetof(). 

llvm-svn: 186888
This commit is contained in:
Rui Ueyama 2013-07-22 23:02:08 +00:00
parent f288626c13
commit d991c50273
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lld/lib/ReaderWriter/PECOFF/ReaderImportHeader.cpp
View File

@ -170,8 +170,8 @@ public:
const char *end = mb->getBufferEnd();
// The size of the string that follows the header.
uint32_t dataSize =
*reinterpret_cast<const support::ulittle32_t *>(buf + 12);
uint32_t dataSize = *reinterpret_cast<const support::ulittle32_t *>(
buf + offsetof(COFF::ImportHeader, SizeOfData));
// Check if the total size is valid. The file header is 20 byte long.
if (end - buf != 20 + dataSize) {
@ -179,13 +179,15 @@ public:
return;
}
uint16_t hint = *reinterpret_cast<const support::ulittle16_t *>(buf + 16);
uint16_t hint = *reinterpret_cast<const support::ulittle16_t *>(
buf + offsetof(COFF::ImportHeader, OrdinalHint));
StringRef symbolName(buf + 20);
StringRef dllName(buf + 20 + symbolName.size() + 1);
const COFFSharedLibraryAtom *dataAtom = addSharedLibraryAtom(
hint, symbolName, dllName);
int type = *reinterpret_cast<const support::ulittle16_t *>(buf + 18) >> 16;
int type = *reinterpret_cast<const support::ulittle16_t *>(
buf + offsetof(COFF::ImportHeader, TypeInfo)) >> 14;
if (type == llvm::COFF::IMPORT_CODE)
addDefinedAtom(symbolName, dllName, dataAtom);