[OpenMP] libomp: fix bug in implementation of distribute construct.

Fixed mistaken iterations distribution between different target regions.

Differential Revision: https://reviews.llvm.org/D118393
This commit is contained in:
AndreyChurbanov 2022-02-11 17:34:26 +03:00
parent cd685f5736
commit d84dedc7d3
2 changed files with 53 additions and 2 deletions

View File

@ -194,8 +194,13 @@ static void __kmp_for_static_init(ident_t *loc, kmp_int32 global_tid,
// we are in DISTRIBUTE construct
schedtype += kmp_sch_static -
kmp_distribute_static; // AC: convert to usual schedule type
tid = th->th.th_team->t.t_master_tid;
team = th->th.th_team->t.t_parent;
if (th->th.th_team->t.t_serialized > 1) {
tid = 0;
team = th->th.th_team;
} else {
tid = th->th.th_team->t.t_master_tid;
team = th->th.th_team->t.t_parent;
}
} else {
tid = __kmp_tid_from_gtid(global_tid);
team = th->th.th_team;

View File

@ -0,0 +1,46 @@
// The test supposes no offload, pure host execution.
// It checks that the bug in implementation of distribute construct is fixed.
// RUN: %libomp-compile-and-run
// UNSUPPORTED: icc
#include <stdio.h>
#include <omp.h>
int main()
{
const int size = 4;
int wrong_counts = 0;
omp_set_num_threads(2);
#pragma omp parallel reduction(+:wrong_counts)
{
int i;
int A[size];
int th = omp_get_thread_num();
for(i = 0; i < size; i++)
A[i] = 0;
#pragma omp target teams distribute map(tofrom: A[:size]) private(i)
for(i = 0; i < size; i++)
{
A[i] = i;
printf("th %d, team %d, i %d\n", th, omp_get_team_num(), i);
}
#pragma omp critical
{
printf("tid = %d\n", th);
for(i = 0; i < size; i++)
{
if (A[i] != i) wrong_counts++;
printf(" %d", A[i]);
}
printf("\n");
}
}
if (wrong_counts) {
printf("failed\n");
} else {
printf("passed\n");
}
return wrong_counts;
}