replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Implement rdar://7415680 - Twine integer support lacks greatness 

Microoptimize Twine's with unsigned and int to not pin their value to
the stack.  This saves stack space in common cases and allows mem2reg
in the caller.  A simple example is:

void foo(const Twine &);
void bar(int x) {
  foo("xyz: " + Twine(x));
}

Before:

__Z3bari:
	subq	$40, %rsp
	movl	%edi, 36(%rsp)
	leaq	L_.str3(%rip), %rax
	leaq	36(%rsp), %rcx
	leaq	8(%rsp), %rdi
	movq	%rax, 8(%rsp)
	movq	%rcx, 16(%rsp)
	movb	$3, 24(%rsp)
	movb	$7, 25(%rsp)
	callq	__Z3fooRKN4llvm5TwineE
	addq	$40, %rsp
	ret

After:

__Z3bari:
	subq	$24, %rsp
	leaq	L_.str3(%rip), %rax
	movq	%rax, (%rsp)
	movslq	%edi, %rax
	movq	%rax, 8(%rsp)
	movb	$3, 16(%rsp)
	movb	$7, 17(%rsp)
	leaq	(%rsp), %rdi
	callq	__Z3fooRKN4llvm5TwineE
	addq	$24, %rsp
	ret

It saves 16 bytes of stack and one instruction in this case.

llvm-svn: 103107
This commit is contained in:
Chris Lattner 2010-05-05 18:40:33 +00:00
parent 1a74a44bf9
commit d7f69cb7ef
2 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
llvm/include/llvm/ADT/Twine.h
View File

@ -99,11 +99,12 @@ namespace llvm {
/// A pointer to a StringRef instance. /// A pointer to a StringRef instance.
StringRefKind, StringRefKind,
/// A pointer to an unsigned int value, to render as an unsigned decimal /// An unsigned int value reinterpreted as a pointer, to render as an
/// integer. /// unsigned decimal integer.
DecUIKind, DecUIKind,
/// A pointer to an int value, to render as a signed decimal integer. /// An int value reinterpreted as a pointer, to render as a signed
/// decimal integer.
DecIKind, DecIKind,
/// A pointer to an unsigned long value, to render as an unsigned decimal /// A pointer to an unsigned long value, to render as an unsigned decimal
@ -259,13 +260,13 @@ namespace llvm {
} }
/// Construct a twine to print \arg Val as an unsigned decimal integer. /// Construct a twine to print \arg Val as an unsigned decimal integer.
explicit Twine(const unsigned int &Val) explicit Twine(unsigned Val)
: LHS(&Val), LHSKind(DecUIKind), RHSKind(EmptyKind) { : LHS((void*)(intptr_t)Val), LHSKind(DecUIKind), RHSKind(EmptyKind) {
} }
/// Construct a twine to print \arg Val as a signed decimal integer. /// Construct a twine to print \arg Val as a signed decimal integer.
explicit Twine(const int &Val) explicit Twine(int Val)
: LHS(&Val), LHSKind(DecIKind), RHSKind(EmptyKind) { : LHS((void*)(intptr_t)Val), LHSKind(DecIKind), RHSKind(EmptyKind) {
} }
/// Construct a twine to print \arg Val as an unsigned decimal integer. /// Construct a twine to print \arg Val as an unsigned decimal integer.

8
llvm/lib/Support/Twine.cpp
View File

@ -48,10 +48,10 @@ void Twine::printOneChild(raw_ostream &OS, const void *Ptr,
OS << *static_cast<const StringRef*>(Ptr); OS << *static_cast<const StringRef*>(Ptr);
break; break;
case Twine::DecUIKind: case Twine::DecUIKind:
OS << *static_cast<const unsigned int*>(Ptr); OS << (unsigned)(uintptr_t)Ptr;
break; break;
case Twine::DecIKind: case Twine::DecIKind:
OS << *static_cast<const int*>(Ptr); OS << (int)(intptr_t)Ptr;
break; break;
case Twine::DecULKind: case Twine::DecULKind:
OS << *static_cast<const unsigned long*>(Ptr); OS << *static_cast<const unsigned long*>(Ptr);
@ -95,10 +95,10 @@ void Twine::printOneChildRepr(raw_ostream &OS, const void *Ptr,
<< static_cast<const StringRef*>(Ptr) << "\""; << static_cast<const StringRef*>(Ptr) << "\"";
break; break;
case Twine::DecUIKind: case Twine::DecUIKind:
OS << "decUI:\"" << *static_cast<const unsigned int*>(Ptr) << "\""; OS << "decUI:\"" << (unsigned)(uintptr_t)Ptr << "\"";
break; break;
case Twine::DecIKind: case Twine::DecIKind:
OS << "decI:\"" << *static_cast<const int*>(Ptr) << "\""; OS << "decI:\"" << (int)(intptr_t)Ptr << "\"";
break; break;
case Twine::DecULKind: case Twine::DecULKind:
OS << "decUL:\"" << *static_cast<const unsigned long*>(Ptr) << "\""; OS << "decUL:\"" << *static_cast<const unsigned long*>(Ptr) << "\"";