Don't end a file name with a dot. It looks odd.
llvm-svn: 187124
This commit is contained in:
parent
c0f037d4db
commit
d3c89041c5
|
@ -665,7 +665,8 @@ static error_code
|
||||||
createTemporaryFile(const Twine &Prefix, StringRef Suffix, int &ResultFD,
|
createTemporaryFile(const Twine &Prefix, StringRef Suffix, int &ResultFD,
|
||||||
llvm::SmallVectorImpl<char> &ResultPath,
|
llvm::SmallVectorImpl<char> &ResultPath,
|
||||||
FSEntity Type) {
|
FSEntity Type) {
|
||||||
return createTemporaryFile(Prefix + "-%%%%%%." + Suffix, ResultFD, ResultPath,
|
const char *Middle = Suffix.empty() ? "-%%%%%%" : "-%%%%%%.";
|
||||||
|
return createTemporaryFile(Prefix + Middle + Suffix, ResultFD, ResultPath,
|
||||||
Type);
|
Type);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -213,6 +213,7 @@ TEST_F(FileSystemTest, TempFiles) {
|
||||||
int FD2;
|
int FD2;
|
||||||
SmallString<64> TempPath2;
|
SmallString<64> TempPath2;
|
||||||
ASSERT_NO_ERROR(fs::createTemporaryFile("prefix", "temp", FD2, TempPath2));
|
ASSERT_NO_ERROR(fs::createTemporaryFile("prefix", "temp", FD2, TempPath2));
|
||||||
|
ASSERT_TRUE(TempPath2.endswith(".temp"));
|
||||||
ASSERT_NE(TempPath.str(), TempPath2.str());
|
ASSERT_NE(TempPath.str(), TempPath2.str());
|
||||||
|
|
||||||
fs::file_status A, B;
|
fs::file_status A, B;
|
||||||
|
@ -230,6 +231,10 @@ TEST_F(FileSystemTest, TempFiles) {
|
||||||
ASSERT_NO_ERROR(fs::exists(Twine(TempPath2), TempFileExists));
|
ASSERT_NO_ERROR(fs::exists(Twine(TempPath2), TempFileExists));
|
||||||
EXPECT_FALSE(TempFileExists);
|
EXPECT_FALSE(TempFileExists);
|
||||||
|
|
||||||
|
SmallString<64> TempPath3;
|
||||||
|
ASSERT_NO_ERROR(fs::createTemporaryFile("prefix", "", TempPath3));
|
||||||
|
ASSERT_FALSE(TempPath3.endswith("."));
|
||||||
|
|
||||||
// Create a hard link to Temp1.
|
// Create a hard link to Temp1.
|
||||||
ASSERT_NO_ERROR(fs::create_hard_link(Twine(TempPath), Twine(TempPath2)));
|
ASSERT_NO_ERROR(fs::create_hard_link(Twine(TempPath), Twine(TempPath2)));
|
||||||
bool equal;
|
bool equal;
|
||||||
|
|
Loading…
Reference in New Issue