replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Don't generate floating point stubs for mips16 code if the function 

is actually an instrinsic that will not occur in libc. This list here
is not exhaustive but fixes the one places in test-suite where this occurs.
I have filed a bug against myself to research the full list and add them
to the array of such cases. In the future, actual stub generation will occur
in a later phase and we won't need this code because we will know at that time
during the compilation that in fact no helper function was even needed.

llvm-svn: 188149
This commit is contained in:
Reed Kotler 2013-08-11 21:30:27 +00:00
parent 5fed3b95db
commit d265e88827
2 changed files with 38 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
llvm/lib/Target/Mips/Mips16HardFloat.cpp
View File

@ -16,6 +16,7 @@
#include "llvm/IR/Module.h"
#include "llvm/Support/Debug.h"
#include "llvm/Support/raw_ostream.h"
#include <algorithm>
#include <string>
static void inlineAsmOut
@ -320,6 +321,17 @@ static void assureFPCallStub(Function &F, Module *M,
new UnreachableInst(Context, BB);
}
//
// Functions that are inline intrinsics don't need helpers.
//
std::string IntrinsicInline[] =
{"fabs"};
bool isIntrinsicInline(Function *F) {
return std::binary_search(
IntrinsicInline, array_endof(IntrinsicInline),
F->getName());
}
//
// Returns of float, double and complex need to be handled with a helper
// function.
@ -372,7 +384,7 @@ static bool fixupFPReturnAndCall
// helper functions
if (Subtarget.getRelocationModel() != Reloc::PIC_ ) {
Function *F_ = CI->getCalledFunction();
if (F_ && needsFPHelperFromSig(*F_)) {
if (F_ && !isIntrinsicInline(F_) && needsFPHelperFromSig(*F_)) {
assureFPCallStub(*F_, M, Subtarget);
Modified=true;
}

25
llvm/test/CodeGen/Mips/f16abs.ll Normal file
View File

@ -0,0 +1,25 @@
; RUN: llc -mtriple=mipsel-linux-gnu -march=mipsel -mcpu=mips16 -soft-float -mips16-hard-float -relocation-model=static < %s | FileCheck %s -check-prefix=static
@y = global double -1.450000e+00, align 8
@x = common global double 0.000000e+00, align 8
; Function Attrs: nounwind optsize
define i32 @main() #0 {
entry:
%0 = load double* @y, align 8
%call = tail call double @fabs(double %0) #2
store double %call, double* @x, align 8
; static-NOT: .ent __call_stub_fp_fabs
; static-NOT: jal fabs
ret i32 0
}
; Function Attrs: nounwind optsize readnone
declare double @fabs(double) #1
attributes #0 = { nounwind optsize "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf"="true" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "unsafe-fp-math"="false" "use-soft-float"="true" }
attributes #1 = { nounwind optsize readnone "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf"="true" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "unsafe-fp-math"="false" "use-soft-float"="true" }
attributes #2 = { nounwind optsize readnone }