replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Simplify. NFC. 

This patch calls getAddend on a relocation only when the relocation is RELA.
That doesn't really improve runtime performance but should improve
readability as the code now matches the function description.

llvm-svn: 298828
This commit is contained in:
Rui Ueyama 2017-03-27 03:41:00 +00:00
parent 74fb7ac2e0
commit ceb5bd59cc
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lld/ELF/Relocations.cpp
View File

@ -554,11 +554,11 @@ static RelExpr adjustExpr(SymbolBody &Body, RelExpr Expr, uint32_t Type,
// input section. // input section.
template <class ELFT, class RelTy> template <class ELFT, class RelTy>
static int64_t computeAddend(const RelTy &Rel, const uint8_t *Buf) { static int64_t computeAddend(const RelTy &Rel, const uint8_t *Buf) {
int64_t A = getAddend<ELFT>(Rel);
uint32_t Type = Rel.getType(Config->IsMips64EL); uint32_t Type = Rel.getType(Config->IsMips64EL);
int64_t A = RelTy::IsRela
? getAddend<ELFT>(Rel)
: Target->getImplicitAddend(Buf + Rel.r_offset, Type);
if (!RelTy::IsRela)
A += Target->getImplicitAddend(Buf + Rel.r_offset, Type);
if (Config->EMachine == EM_PPC64 && Config->Pic && Type == R_PPC64_TOC) if (Config->EMachine == EM_PPC64 && Config->Pic && Type == R_PPC64_TOC)
A += getPPC64TocBase(); A += getPPC64TocBase();
return A; return A;