Pull CodeGenFunction::GetUndefRValue() out of EmitUnsupportedRValue.

llvm-svn: 63845
This commit is contained in:
Daniel Dunbar 2009-02-05 07:09:07 +00:00
parent 9103df1688
commit c79407fc40
3 changed files with 20 additions and 19 deletions

View File

@ -1430,17 +1430,11 @@ RValue CodeGenFunction::EmitCall(const CGFunctionInfo &CallInfo,
return RValue::get(CI);
case ABIArgInfo::Ignore:
if (RetTy->isVoidType())
return RValue::get(0);
// If we are ignoring an argument that had a result, make sure to
// construct the appropriate return value for our caller.
if (CodeGenFunction::hasAggregateLLVMType(RetTy)) {
llvm::Value *Res =
llvm::UndefValue::get(llvm::PointerType::getUnqual(ConvertType(RetTy)));
return RValue::getAggregate(Res);
}
return RValue::get(llvm::UndefValue::get(ConvertType(RetTy)));
return GetUndefRValue(RetTy);
if (RetTy->isVoidType())
return RValue::get(0);
case ABIArgInfo::Coerce: {
// FIXME: Avoid the conversion through memory if possible.

View File

@ -83,23 +83,27 @@ unsigned CodeGenFunction::getAccessedFieldNo(unsigned Idx,
// LValue Expression Emission
//===----------------------------------------------------------------------===//
RValue CodeGenFunction::EmitUnsupportedRValue(const Expr *E,
const char *Name) {
ErrorUnsupported(E, Name);
if (const ComplexType *CTy = E->getType()->getAsComplexType()) {
RValue CodeGenFunction::GetUndefRValue(QualType Ty) {
if (Ty->isVoidType()) {
return RValue::get(0);
} else if (const ComplexType *CTy = Ty->getAsComplexType()) {
const llvm::Type *EltTy = ConvertType(CTy->getElementType());
llvm::Value *U = llvm::UndefValue::get(EltTy);
return RValue::getComplex(std::make_pair(U, U));
} else if (hasAggregateLLVMType(E->getType())) {
const llvm::Type *Ty =
llvm::PointerType::getUnqual(ConvertType(E->getType()));
return RValue::getAggregate(llvm::UndefValue::get(Ty));
} else if (hasAggregateLLVMType(Ty)) {
const llvm::Type *LTy = llvm::PointerType::getUnqual(ConvertType(Ty));
return RValue::getAggregate(llvm::UndefValue::get(LTy));
} else {
const llvm::Type *Ty = ConvertType(E->getType());
return RValue::get(llvm::UndefValue::get(Ty));
return RValue::get(llvm::UndefValue::get(ConvertType(Ty)));
}
}
RValue CodeGenFunction::EmitUnsupportedRValue(const Expr *E,
const char *Name) {
ErrorUnsupported(E, Name);
return GetUndefRValue(E->getType());
}
LValue CodeGenFunction::EmitUnsupportedLValue(const Expr *E,
const char *Name) {
ErrorUnsupported(E, Name);

View File

@ -450,6 +450,9 @@ public:
// LValue Expression Emission
//===--------------------------------------------------------------------===//
/// GetUndefRValue - Get an appropriate 'undef' rvalue for the given type.
RValue GetUndefRValue(QualType Ty);
/// EmitUnsupportedRValue - Emit a dummy r-value using the type of E
/// and issue an ErrorUnsupported style diagnostic (using the
/// provided Name).