From c593f5e6711a68078546cce6e8149180f1dba649 Mon Sep 17 00:00:00 2001 From: Mikael Holmen Date: Thu, 11 Jul 2019 06:50:10 +0000 Subject: [PATCH] [clang-doc] Silence compiler warning with gcc 7.4 [NFC] Without the fix gcc 7.4.0 complains with /data/repo/master/clang-tools-extra/clang-doc/HTMLGenerator.cpp: In member function 'llvm::SmallString<16> clang::doc::{anonymous}::HTMLTag::ToString() const': /data/repo/master/clang-tools-extra/clang-doc/HTMLGenerator.cpp:165:1: error: control reaches end of non-void function [-Werror=return-type] } ^ /data/repo/master/clang-tools-extra/clang-doc/HTMLGenerator.cpp: In member function 'bool clang::doc::{anonymous}::HTMLTag::HasInlineChildren() const': /data/repo/master/clang-tools-extra/clang-doc/HTMLGenerator.cpp:142:1: error: control reaches end of non-void function [-Werror=return-type] } ^ /data/repo/master/clang-tools-extra/clang-doc/HTMLGenerator.cpp: In member function 'bool clang::doc::{anonymous}::HTMLTag::IsSelfClosing() const': /data/repo/master/clang-tools-extra/clang-doc/HTMLGenerator.cpp:126:1: error: control reaches end of non-void function [-Werror=return-type] } ^ cc1plus: all warnings being treated as errors llvm-svn: 365736 --- clang-tools-extra/clang-doc/HTMLGenerator.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/clang-tools-extra/clang-doc/HTMLGenerator.cpp b/clang-tools-extra/clang-doc/HTMLGenerator.cpp index 12ba68404094..bed27f0e41e3 100644 --- a/clang-tools-extra/clang-doc/HTMLGenerator.cpp +++ b/clang-tools-extra/clang-doc/HTMLGenerator.cpp @@ -123,6 +123,7 @@ bool HTMLTag::IsSelfClosing() const { case HTMLTag::TAG_LI: return false; } + llvm_unreachable("Unhandled HTMLTag::TagType"); } bool HTMLTag::HasInlineChildren() const { @@ -139,6 +140,7 @@ bool HTMLTag::HasInlineChildren() const { case HTMLTag::TAG_UL: return false; } + llvm_unreachable("Unhandled HTMLTag::TagType"); } llvm::SmallString<16> HTMLTag::ToString() const { @@ -162,6 +164,7 @@ llvm::SmallString<16> HTMLTag::ToString() const { case HTMLTag::TAG_LI: return llvm::SmallString<16>("li"); } + llvm_unreachable("Unhandled HTMLTag::TagType"); } void TextNode::Render(llvm::raw_ostream &OS, int IndentationLevel) {