replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[Support] Always wait for GraphViz before opening the viewer 

Summary:
When calling DisplayGraph and a PS viewer is chosen, two programs are executed: The GraphViz generator and the PostScript viewer. Always for the generator to finish to ensure that the .ps file is written before opening the viewer for that file. DisplayGraph's wait parameter refers to whether to wait until the user closes the viewer.

This happened on Windows and if none of the options to open the .dot file directly applies, also on Linux.

Reviewers: Bigcheese, chandlerc, aaron.ballman

Subscribers: dwiberg, aaron.ballman, llvm-commits

Differential Revision: http://reviews.llvm.org/D11876

llvm-svn: 245289
This commit is contained in:
Michael Kruse 2015-08-18 12:13:57 +00:00
parent e69e1141d9
commit c0a8414c1c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
llvm/lib/Support/GraphWriter.cpp
View File

@ -219,7 +219,7 @@ bool llvm::DisplayGraph(StringRef FilenameRef, bool wait,
errs() << "Running '" << GeneratorPath << "' program... ";
if (ExecGraphViewer(GeneratorPath, args, Filename, wait, ErrMsg))
if (ExecGraphViewer(GeneratorPath, args, Filename, true, ErrMsg))
return true;
args.clear();