replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[COFF] Add support for IMAGE_REL_ARM64_SECREL 

I never ran into this until lld-link started enabling debug output
by default for the mingw mode. I haven't been able to verify that
this actually behaves correctly, but this relocation is handled
identically on all other architectures so far.

Differential Revision: https://reviews.llvm.org/D39754

llvm-svn: 317669
This commit is contained in:
Martin Storsjo 2017-11-08 07:31:50 +00:00
parent a8c5460c8a
commit bfe2fed2c4
2 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lld/COFF/Chunks.cpp
View File

@ -224,6 +224,7 @@ void SectionChunk::applyRelARM64(uint8_t *Off, uint16_t Type, OutputSection *OS,
case IMAGE_REL_ARM64_ADDR32: add32(Off, S + Config->ImageBase); break;
case IMAGE_REL_ARM64_ADDR32NB: add32(Off, S); break;
case IMAGE_REL_ARM64_ADDR64: add64(Off, S + Config->ImageBase); break;
case IMAGE_REL_ARM64_SECREL: applySecRel(this, Off, OS, S); break;
default:
fatal("unsupported relocation type 0x" + Twine::utohexstr(Type));
}

15
lld/test/COFF/arm64-relocs-imports.test
View File

@ -37,12 +37,13 @@
# BEFORE: 70: 08 00 00 00 <unknown>
# BEFORE: 74: 00 00 00 00 <unknown>
# BEFORE: 78: 01 00 00 00 <unknown>
# BEFORE: 7c: 01 00 00 00 <unknown>
# AFTER: Disassembly of section .text:
# AFTER: 140002000: fe 0f 1f f8 str x30, [sp, #-16]!
# AFTER: 140002004: e0 ff ff f0 adrp x0, #-4096
# AFTER: 140002008: 00 18 00 91 add x0, x0, #6
# AFTER: 14000200c: 1c 00 00 94 bl #112
# AFTER: 14000200c: 1d 00 00 94 bl #116
# AFTER: 140002010: 00 21 40 39 ldrb w0, [x8, #8]
# AFTER: 140002014: 00 11 40 79 ldrh w0, [x8, #8]
# AFTER: 140002018: 00 09 40 b9 ldr w0, [x8, #8]
@ -70,9 +71,10 @@
# AFTER: 140002070: 10 10 00 40 <unknown>
# AFTER: 140002074: 01 00 00 00 <unknown>
# AFTER: 140002078: 09 10 00 00 <unknown>
# AFTER: 14000207c: 10 00 00 b0 adrp x16, #4096
# AFTER: 140002080: 10 1e 40 f9 ldr x16, [x16, #56]
# AFTER: 140002084: 00 02 1f d6 br x16
# AFTER: 14000207c: 09 00 00 00 <unknown>
# AFTER: 140002080: 10 00 00 b0 adrp x16, #4096
# AFTER: 140002084: 10 1e 40 f9 ldr x16, [x16, #56]
# AFTER: 140002088: 00 02 1f d6 br x16
--- !COFF
header:
@ -82,7 +84,7 @@ sections:
- Name: .text
Characteristics: [ IMAGE_SCN_CNT_CODE, IMAGE_SCN_MEM_EXECUTE, IMAGE_SCN_MEM_READ ]
Alignment: 4
SectionData: FE0F1FF80000009000080091000000940001403900014079000140B9000140F90001003900010079000100B9000100F90001403D0001407D000140BD000140FD0001C03D0001003D0001007D000100BD000100FD0001803D000540F9201A01B000FC4FF9E0031F2AFE0741F8C0035FD6080000000000000001000000
SectionData: FE0F1FF80000009000080091000000940001403900014079000140B9000140F90001003900010079000100B9000100F90001403D0001407D000140BD000140FD0001C03D0001003D0001007D000100BD000100FD0001803D000540F9201A01B000FC4FF9E0031F2AFE0741F8C0035FD608000000000000000100000001000000
Relocations:
- VirtualAddress: 4
SymbolName: .Lstr
@ -162,6 +164,9 @@ sections:
- VirtualAddress: 120
SymbolName: .Lglobal
Type: IMAGE_REL_ARM64_ADDR32NB
- VirtualAddress: 124
SymbolName: .Lglobal
Type: IMAGE_REL_ARM64_SECREL
- Name: .data
Characteristics: [ IMAGE_SCN_CNT_INITIALIZED_DATA, IMAGE_SCN_MEM_READ, IMAGE_SCN_MEM_WRITE ]
Alignment: 4