replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

For PR1099: 

Partial fix for this PR. Default function parameters to signed integer, just
like everything else in CBE. The bug was caused by incorrectly introducing
parameter attributes feature by choosing "signed" parameter if the
SExtAttribute was specified. Howeer, if no attribute is specified, this
causes it to become unsigned which is incorrect. Reversing the logic so
that signedness is detected by "not ZExtAttribute" set fixes the issue.

This fixes 197.parser but there is more to do. Any comparison and possibly
other operators involving arguments may need to correctly cast the parameter
before its use, depending on the sign of the operator.

llvm-svn: 33034
This commit is contained in:
Reid Spencer 2007-01-09 06:38:06 +00:00
parent d3ee816c17
commit bf38bf7143
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
llvm/lib/Target/CBackend/Writer.cpp
View File

@ -348,7 +348,7 @@ void CWriter::printStructReturnPointerFunctionType(std::ostream &Out,
if (PrintedType)
FunctionInnards << ", ";
printType(FunctionInnards, *I,
/*isSigned=*/FTy->paramHasAttr(Idx, FunctionType::SExtAttribute), "");
/*isSigned=*/!FTy->paramHasAttr(Idx, FunctionType::ZExtAttribute), "");
PrintedType = true;
}
if (FTy->isVarArg()) {
@ -360,7 +360,7 @@ void CWriter::printStructReturnPointerFunctionType(std::ostream &Out,
FunctionInnards << ')';
std::string tstr = FunctionInnards.str();
printType(Out, RetTy,
/*isSigned=*/FTy->paramHasAttr(0, FunctionType::SExtAttribute), tstr);
/*isSigned=*/!FTy->paramHasAttr(0, FunctionType::SExtAttribute), tstr);
}
std::ostream &
@ -417,7 +417,7 @@ std::ostream &CWriter::printType(std::ostream &Out, const Type *Ty,
if (I != FTy->param_begin())
FunctionInnards << ", ";
printType(FunctionInnards, *I,
/*isSigned=*/FTy->paramHasAttr(Idx, FunctionType::SExtAttribute), "");
/*isSigned=*/!FTy->paramHasAttr(Idx, FunctionType::ZExtAttribute), "");
++Idx;
}
if (FTy->isVarArg()) {
@ -429,7 +429,7 @@ std::ostream &CWriter::printType(std::ostream &Out, const Type *Ty,
FunctionInnards << ')';
std::string tstr = FunctionInnards.str();
printType(Out, FTy->getReturnType(),
/*isSigned=*/FTy->paramHasAttr(0, FunctionType::SExtAttribute), tstr);
/*isSigned=*/!FTy->paramHasAttr(0, FunctionType::ZExtAttribute), tstr);
return Out;
}
case Type::StructTyID: {
@ -1775,7 +1775,7 @@ void CWriter::printFunctionSignature(const Function *F, bool Prototype) {
else
ArgName = "";
printType(FunctionInnards, I->getType(),
/*isSigned=*/FT->paramHasAttr(Idx, FunctionType::SExtAttribute),
/*isSigned=*/!FT->paramHasAttr(Idx, FunctionType::ZExtAttribute),
ArgName);
PrintedArg = true;
++Idx;
@ -1796,7 +1796,7 @@ void CWriter::printFunctionSignature(const Function *F, bool Prototype) {
for (; I != E; ++I) {
if (PrintedArg) FunctionInnards << ", ";
printType(FunctionInnards, *I,
/*isSigned=*/FT->paramHasAttr(Idx, FunctionType::SExtAttribute));
/*isSigned=*/!FT->paramHasAttr(Idx, FunctionType::ZExtAttribute));
PrintedArg = true;
++Idx;
}
@ -1823,7 +1823,8 @@ void CWriter::printFunctionSignature(const Function *F, bool Prototype) {
}
// Print out the return type and the signature built above.
printType(Out, RetTy, FT->paramHasAttr(0, FunctionType::SExtAttribute),
printType(Out, RetTy,
/*isSigned=*/!FT->paramHasAttr(0, FunctionType::ZExtAttribute),
FunctionInnards.str());
}
@ -2516,7 +2517,7 @@ void CWriter::visitCallInst(CallInst &I) {
(*AI)->getType() != FTy->getParamType(ArgNo)) {
Out << '(';
printType(Out, FTy->getParamType(ArgNo),
/*isSigned=*/FTy->paramHasAttr(Idx, FunctionType::SExtAttribute));
/*isSigned=*/!FTy->paramHasAttr(Idx, FunctionType::ZExtAttribute));
Out << ')';
}
writeOperand(*AI);