replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix fetching the symbol table of a thin archive. 

We were trying to read it as an external file.

llvm-svn: 242926
This commit is contained in:
Rafael Espindola 2015-07-22 19:34:26 +00:00
parent 240bd9c875
commit be9ab2682e
3 changed files with 24 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
llvm/include/llvm/Object/Archive.h
View File

@ -62,6 +62,8 @@ public:
return reinterpret_cast<const ArchiveMemberHeader *>(Data.data());
}
bool isThinMember() const;
public:
Child(const Archive *Parent, const char *Start);

17
llvm/lib/Object/Archive.cpp
View File

@ -87,17 +87,17 @@ Archive::Child::Child(const Archive *Parent, const char *Start)
if (!Start)
return;
const ArchiveMemberHeader *Header =
reinterpret_cast<const ArchiveMemberHeader *>(Start);
uint64_t Size = sizeof(ArchiveMemberHeader);
if (!Parent->IsThin || Header->getName() == "/" || Header->getName() == "//")
Size += Header->getSize();
Data = StringRef(Start, Size);
if (!isThinMember()) {
Size += getRawSize();
Data = StringRef(Start, Size);
}
// Setup StartOfFile and PaddingBytes.
StartOfFile = sizeof(ArchiveMemberHeader);
// Don't include attached name.
StringRef Name = Header->getName();
StringRef Name = getRawName();
if (Name.startswith("#1/")) {
uint64_t NameSize;
if (Name.substr(3).rtrim(" ").getAsInteger(10, NameSize))
@ -116,8 +116,13 @@ uint64_t Archive::Child::getRawSize() const {
return getHeader()->getSize();
}
bool Archive::Child::isThinMember() const {
StringRef Name = getHeader()->getName();
return Parent->IsThin && Name != "/" && Name != "//";
}
ErrorOr<StringRef> Archive::Child::getBuffer() const {
if (!Parent->IsThin)
if (!isThinMember())
return StringRef(Data.data() + StartOfFile, getSize());
ErrorOr<StringRef> Name = getName();
if (std::error_code EC = Name.getError())

11
llvm/test/Object/archive-symtab.test
View File

@ -8,6 +8,17 @@ CHECK-NEXT: foo in trivial-object-test2.elf-x86-64
CHECK-NEXT: main in trivial-object-test2.elf-x86-64
CHECK-NOT: bar
RUN: rm -f %t.a
RUN: llvm-ar rcT %t.a %p/Inputs/trivial-object-test.elf-x86-64 %p/Inputs/trivial-object-test2.elf-x86-64
RUN: llvm-nm -M %t.a | FileCheck --check-prefix=THIN %s
THIN: Archive map
THIN-NEXT: main in {{.*}}/Inputs/trivial-object-test.elf-x86-64
THIN-NEXT: foo in {{.*}}/Inputs/trivial-object-test2.elf-x86-64
THIN-NEXT: main in {{.*}}/Inputs/trivial-object-test2.elf-x86-64
CHECK: trivial-object-test.elf-x86-64:
CHECK-NEXT: U SomeOtherFunction
CHECK-NEXT: 0000000000000000 T main