replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Revert "Add Available Externally linkage type to isWeakForLinker()" 

This reverts r255043, as per post-review concern were raised on the correctness.

From: Mehdi Amini <mehdi.amini@apple.com>
llvm-svn: 255045
This commit is contained in:
Mehdi Amini 2015-12-08 19:13:31 +00:00
parent 69e3ae8d4b
commit bddfbeaf59
2 changed files with 1 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
llvm/include/llvm/IR/GlobalValue.h
View File

@ -256,8 +256,7 @@ public:
static bool isWeakForLinker(LinkageTypes Linkage) {
return Linkage == WeakAnyLinkage || Linkage == WeakODRLinkage ||
Linkage == LinkOnceAnyLinkage || Linkage == LinkOnceODRLinkage ||
Linkage == CommonLinkage || Linkage == ExternalWeakLinkage ||
Linkage == AvailableExternallyLinkage;
Linkage == CommonLinkage || Linkage == ExternalWeakLinkage;
}
bool hasExternalLinkage() const { return isExternalLinkage(Linkage); }

22
llvm/test/Transforms/GlobalOpt/available_externally_global_ctors.ll
View File

@ -1,22 +0,0 @@
target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-apple-macosx10.11.0"
; RUN: opt -S -globalopt < %s | FileCheck %s
; Verify that the initialization of the available_externally global is not eliminated
; CHECK: @llvm.global_ctors = appending global [1 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 65535, void ()* @foo_static_init, i8* null }]
@llvm.global_ctors = appending global [1 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 65535, void ()* @foo_static_init, i8* null }]
@foo_external = available_externally global void ()* null
define internal void @foo_static_init() {
entry:
store void ()* @foo_impl, void ()** @foo_external
ret void
}
define internal void @foo_impl() {
entry:
ret void
}