replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ARM: allow both vfma and vfms intrinsics on v7. 

The main purpose here is that vfma/vfms should be symmetric, and they are
supported on most v7 cores.

The new ArchGuard is suggested by ACLE but prophylactic for us. Almost all CPUs
with NEON *will* have vfma, and the few exceptions I know of (e.g. Cortex-A8)
are incorrectly modelled by Clang so can't trigger a test.

Fortunately, they're getting rarer. But if we ever do support them properly
arm_neon.h should now do the right thing.

llvm-svn: 259537
This commit is contained in:
Tim Northover 2016-02-02 18:02:10 +00:00
parent 1fcd610c94
commit bbac6d7c1b
2 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
clang/include/clang/Basic/arm_neon.td
View File

@ -824,7 +824,10 @@ def VREINTERPRET
////////////////////////////////////////////////////////////////////////////////
// Vector fused multiply-add operations
def VFMA : SInst<"vfma", "dddd", "fQf">;
let ArchGuard = "defined(__ARM_FEATURE_FMA)" in {
def VFMA : SInst<"vfma", "dddd", "fQf">;
def VFMS : SInst<"vfms", "dddd", "fQf">;
}
////////////////////////////////////////////////////////////////////////////////
// fp16 vector operations
@ -908,7 +911,7 @@ def FDIV : IOpInst<"vdiv", "ddd", "fdQfQd", OP_DIV>;
////////////////////////////////////////////////////////////////////////////////
// Vector fused multiply-add operations
def FMLA : SInst<"vfma", "dddd", "dQd">;
def FMLS : SInst<"vfms", "dddd", "fdQfQd">;
def FMLS : SInst<"vfms", "dddd", "dQd">;
////////////////////////////////////////////////////////////////////////////////
// MUL, MLA, MLS, FMA, FMS definitions with scalar argument

12
clang/test/Sema/arm_vfma.c Normal file
View File

@ -0,0 +1,12 @@
// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon -fsyntax-only -verify %s
#include <arm_neon.h>
// expected-no-diagnostics
void func(float32x2_t v2f32, float32x4_t v4f32) {
vfma_f32(v2f32, v2f32, v2f32);
vfmaq_f32(v4f32, v4f32, v4f32);
vfms_f32(v2f32, v2f32, v2f32);
vfmsq_f32(v4f32, v4f32, v4f32);
}