From b75dd0c9a936112d898523291834482585921b03 Mon Sep 17 00:00:00 2001 From: Reid Kleckner Date: Tue, 16 Feb 2016 19:16:28 +0000 Subject: [PATCH] Exclude PCH/missing-file.cpp on Windows, it does not pass reliably Tag the test with "REQUIRES: can-remove-opened-file", which is what we use for the similar test Modules/explicit-build-missing-file.cpp. llvm-svn: 260994 --- clang/test/PCH/missing-file.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/clang/test/PCH/missing-file.cpp b/clang/test/PCH/missing-file.cpp index 502a9db65799..8bdb08d6373d 100644 --- a/clang/test/PCH/missing-file.cpp +++ b/clang/test/PCH/missing-file.cpp @@ -4,16 +4,15 @@ // RUN: echo 'struct S{char c; int i; }; void foo() {}' > %t.h // RUN: echo 'template void tf() { T::foo(); }' >> %t.h // RUN: %clang_cc1 -x c++ -emit-pch -o %t.h.pch %t.h - -// %t.h might be touched by scanners as a hot file on Windows, -// to fail to remove %.h with single run. -// FIXME: Do we really want to work around bugs in virus checkers here? -// RUN: rm %t.h || rm %t.h || rm %t.h +// RUN: rm %t.h // Check diagnostic with location in original source: // RUN: not %clang_cc1 -include-pch %t.h.pch -emit-obj -o %t.o %s 2> %t.stderr // RUN: grep 'could not find file' %t.stderr +// Oftentimes on Windows there are open handles, and deletion will fail. +// REQUIRES: can-remove-opened-file + void qq(S*) {} #ifdef REDECL