replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Improve the diagnostic for -Wcustom-atomic-properties. Suggestion by Fariborz! 

llvm-svn: 124620
This commit is contained in:
Argyrios Kyrtzidis 2011-01-31 23:20:03 +00:00
parent c30c39982d
commit b5b5a59f18
3 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang/include/clang/Basic/DiagnosticSemaKinds.td
View File

@ -387,7 +387,7 @@ def warn_atomic_property_rule : Warning<
"writable atomic property %0 cannot pair a synthesized setter/getter "
"with a user defined setter/getter">;
def warn_default_atomic_custom_getter_setter : Warning<
"atomic by default property %0 has a user defined setter/getter "
"atomic by default property %0 has a user defined %select{getter|setter}1 "
"(property should be marked 'atomic' if this is intended)">,
InGroup<CustomAtomic>, DefaultIgnore;
def err_use_continuation_class : Error<

4
clang/lib/Sema/SemaObjCProperty.cpp
View File

@ -1096,13 +1096,13 @@ Sema::AtomicPropertySetterGetterRules (ObjCImplDecl* IMPDecl,
if (GetterMethod) {
Diag(GetterMethod->getLocation(),
diag::warn_default_atomic_custom_getter_setter)
<< Property->getIdentifier();
<< Property->getIdentifier() << 0;
Diag(Property->getLocation(), diag::note_property_declare);
}
if (SetterMethod) {
Diag(SetterMethod->getLocation(),
diag::warn_default_atomic_custom_getter_setter)
<< Property->getIdentifier();
<< Property->getIdentifier() << 1;
Diag(Property->getLocation(), diag::note_property_declare);
}
}

14
clang/test/SemaObjC/custom-atomic-property.m
View File

@ -5,6 +5,16 @@
@end
@implementation Foo
-(Foo*)myProp {return 0;} // expected-warning {{atomic by default property 'myProp' has a user defined setter/getter (property should be marked 'atomic' if this is intended)}}
-(void)setMyProp:(Foo*)e {} // expected-warning {{atomic by default property 'myProp' has a user defined setter/getter (property should be marked 'atomic' if this is intended)}}
-(Foo*)myProp {return 0;} // expected-warning {{atomic by default property 'myProp' has a user defined getter (property should be marked 'atomic' if this is intended)}}
-(void)setMyProp:(Foo*)e {} // expected-warning {{atomic by default property 'myProp' has a user defined setter (property should be marked 'atomic' if this is intended)}}
@end
@interface Foo2 {
Foo *myProp;
}
@property (assign) Foo *myProp;
@end
@implementation Foo2
@synthesize myProp; // no warnings.
@end