replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix crash on invalid. 

We would fail an assert if a shared library had a local symbol after
sh_info.

llvm-svn: 320667
This commit is contained in:
Rafael Espindola 2017-12-14 05:01:49 +00:00
parent 5dd72adbec
commit b308cace84
3 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lld/ELF/SymbolTable.cpp
View File

@ -495,7 +495,11 @@ void SymbolTable::addShared(StringRef Name, SharedFile<ELFT> *File,
if (WasInserted || ((S->isUndefined() || S->isLazy()) &&
S->getVisibility() == STV_DEFAULT)) {
uint8_t Binding = S->Binding;
replaceSymbol<SharedSymbol>(S, File, Name, Sym.getBinding(), Sym.st_other,
uint8_t OrigBinding = Sym.getBinding();
if (OrigBinding == STB_LOCAL)
error("Found local symbol '" + Name +
"' in global part of symbol table in file " + toString(File));
replaceSymbol<SharedSymbol>(S, File, Name, OrigBinding, Sym.st_other,
Sym.getType(), Sym.st_value, Sym.st_size,
Alignment, VerdefIndex);
if (!WasInserted) {

BIN
lld/test/ELF/Inputs/local-symbol-in-dso.so Executable file
View File

Binary file not shown.

5
lld/test/ELF/invalid-local-symbol-in-dso.s Normal file
View File

@ -0,0 +1,5 @@
# RUN: llvm-mc %s -o %t.o -filetype=obj -triple x86_64-pc-linux
# We used to crash on this
# RUN: not ld.lld %t.o %p/Inputs/local-symbol-in-dso.so -o %t 2>&1 | FileCheck %s
# CHECK: Found local symbol 'foo' in global part of symbol table in file {{.*}}local-symbol-in-dso.so