replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix a crasher in StoreManager::InvalidateRegion() caused by using the 

'cast type' of a region to invalidate its binding.  This only occurs
when using RegionStoreManager, as it records the cast type.  I'm
currently considering removing the notion of a cast type (see
comments in code).

llvm-svn: 76719
This commit is contained in:
Ted Kremenek 2009-07-22 04:23:20 +00:00
parent 6bad1376a2
commit b2d0409d50
2 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
clang/lib/Analysis/Store.cpp
View File

@ -258,6 +258,13 @@ const GRState *StoreManager::InvalidateRegion(const GRState *state,
const TypedRegion *TR = cast<TypedRegion>(R);
QualType T = TR->getValueType(Ctx);
// FIXME: The code causes a crash when using RegionStore on the test case
// 'test_invalidate_cast_int' (misc-ps.m). Consider removing it
// permanently. Region casts are probably not too strict to handle
// the transient interpretation of memory. Instead we can use the QualType
// passed to 'Retrieve' and friends to determine the most current
// interpretation of memory when it is actually used.
#if 0
// If the region is cast to another type, use that type.
if (const QualType *CastTy = getCastType(state, R)) {
assert(!(*CastTy)->isObjCObjectPointerType());
@ -270,6 +277,7 @@ const GRState *StoreManager::InvalidateRegion(const GRState *state,
if (!(Loc::IsLocType(T) && !Loc::IsLocType(NewT)))
T = NewT;
}
#endif
if (Loc::IsLocType(T) || (T->isIntegerType() && T->isScalarType())) {
SVal V = ValMgr.getConjuredSymbolVal(E, T, Count);

11
clang/test/Analysis/misc-ps.m
View File

@ -459,3 +459,14 @@ void PR4594() {
char **foo = buf;
*foo = "test";
}
// Test invalidation logic where an integer is casted to an array with a
// different sign and then invalidated.
void test_invalidate_cast_int() {
void test_invalidate_cast_int_aux(unsigned *i);
signed i;
test_invalidate_cast_int_aux((unsigned*) &i);
if (i < 0)
return;
}