replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[lto] Don't add variables with private linkage to the symbol table. 

Summary:
This causes the issue in PR26872 to go away now that we aren't creating
symbols for the string literals, but that may just be concealing a
deeper problem, so best to keep that PR open.

Reviewers: rafael

Subscribers: Bigcheese, llvm-commits, joker.eph

Differential Revision: http://reviews.llvm.org/D17971

llvm-svn: 262968
This commit is contained in:
Sean Silva 2016-03-08 23:50:56 +00:00
parent bbbe618467
commit b284e71e03
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lld/ELF/InputFiles.cpp
View File

@ -440,10 +440,13 @@ void BitcodeFile::parse(DenseSet<StringRef> &ComdatGroups) {
for (const BasicSymbolRef &Sym : Obj->symbols()) {
uint8_t Visibility = STV_DEFAULT;
const GlobalValue *GV = Obj->getSymbolGV(Sym.getRawDataRefImpl());
uint32_t Flags = Sym.getFlags();
if (GV) {
if (const Comdat *C = GV->getComdat())
if (!KeptComdats.count(C))
continue;
if (!(Flags & object::BasicSymbolRef::SF_Global))
continue;
Visibility = getGvVisibility(GV);
}
@ -453,7 +456,6 @@ void BitcodeFile::parse(DenseSet<StringRef> &ComdatGroups) {
StringRef NameRef = Saver.save(StringRef(Name));
SymbolBody *Body;
uint32_t Flags = Sym.getFlags();
bool IsWeak = Flags & BasicSymbolRef::SF_Weak;
if (Flags & BasicSymbolRef::SF_Undefined) {
Body = new (Alloc) Undefined(NameRef, IsWeak, Visibility, false);

9
lld/test/ELF/lto/linkage.ll Normal file
View File

@ -0,0 +1,9 @@
; REQUIRES: x86
; RUN: llvm-as %s -o %t1.o
; RUN: ld.lld -m elf_x86_64 %t1.o %t1.o -o %t.so -shared
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
; Should not encounter a duplicate symbol error for @.str
@.str = private unnamed_addr constant [4 x i8] c"Hey\00", align 1