replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add comment to r363191 code as requested in code review 

llvm-svn: 363195
This commit is contained in:
Reid Kleckner 2019-06-12 19:50:06 +00:00
parent 2aa5ada267
commit b05ce7f9f7
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
clang/lib/AST/ASTContext.cpp
View File

@ -9804,8 +9804,11 @@ static GVALinkage basicGVALinkageForVariable(const ASTContext &Context,
// was marked inline. MSVC 14.21.27702 headers define _Is_integral in a
// header this way, and we don't want to emit non-discardable definitions
// of these variables in every TU that includes <type_traits>. This
// behavior can be removed if the headers change to explicitly mark such
// variable template specializations inline.
// behavior is non-conforming, since another TU could use an extern
// template declaration for this variable, but for constexpr variables,
// it's unlikely for a user to want to do that. This behavior can be
// removed if the headers change to explicitly mark such variable template
// specializations inline.
if (isa<VarTemplateSpecializationDecl>(VD) && VD->isConstexpr())
return GVA_DiscardableODR;