[MS] Win64 va_arg should expect large arguments to be passed indirectly
Fixes PR20569 llvm-svn: 279774
This commit is contained in:
parent
3495647d0d
commit
b04449d97a
|
@ -3651,7 +3651,17 @@ void WinX86_64ABIInfo::computeInfo(CGFunctionInfo &FI) const {
|
|||
|
||||
Address WinX86_64ABIInfo::EmitVAArg(CodeGenFunction &CGF, Address VAListAddr,
|
||||
QualType Ty) const {
|
||||
return emitVoidPtrVAArg(CGF, VAListAddr, Ty, /*indirect*/ false,
|
||||
|
||||
bool IsIndirect = false;
|
||||
|
||||
// MS x64 ABI requirement: "Any argument that doesn't fit in 8 bytes, or is
|
||||
// not 1, 2, 4, or 8 bytes, must be passed by reference."
|
||||
if (isAggregateTypeForABI(Ty) || Ty->isMemberPointerType()) {
|
||||
uint64_t Width = getContext().getTypeSize(Ty);
|
||||
IsIndirect = Width > 64 || !llvm::isPowerOf2_64(Width);
|
||||
}
|
||||
|
||||
return emitVoidPtrVAArg(CGF, VAListAddr, Ty, IsIndirect,
|
||||
CGF.getContext().getTypeInfoInChars(Ty),
|
||||
CharUnits::fromQuantity(8),
|
||||
/*allowHigherAlign*/ false);
|
||||
|
|
|
@ -45,24 +45,27 @@ void __attribute__((ms_abi)) f4(int a, ...) {
|
|||
// WIN64-NEXT: %[[AP_NEXT:.*]] = getelementptr inbounds i8, i8* %[[AP_CUR]], i64 8
|
||||
// WIN64-NEXT: store i8* %[[AP_NEXT]], i8** %[[AP]]
|
||||
// WIN64-NEXT: bitcast i8* %[[AP_CUR]] to i32*
|
||||
// FIXME: These are different now. We probably need __builtin_ms_va_arg.
|
||||
double _Complex c = __builtin_va_arg(ap, double _Complex);
|
||||
// FREEBSD: %[[AP_CUR2:.*]] = load i8*, i8** %[[AP]]
|
||||
// FREEBSD-NEXT: %[[AP_NEXT2:.*]] = getelementptr inbounds i8, i8* %[[AP_CUR2]], i64 16
|
||||
// FREEBSD-NEXT: store i8* %[[AP_NEXT2]], i8** %[[AP]]
|
||||
// FREEBSD-NEXT: bitcast i8* %[[AP_CUR2]] to { double, double }*
|
||||
// WIN64: %[[AP_CUR2:.*]] = load i8*, i8** %[[AP]]
|
||||
// WIN64-NEXT: %[[AP_NEXT2:.*]] = getelementptr inbounds i8, i8* %[[AP_CUR2]], i64 16
|
||||
// WIN64-NEXT: %[[AP_NEXT2:.*]] = getelementptr inbounds i8, i8* %[[AP_CUR2]], i64 8
|
||||
// WIN64-NEXT: store i8* %[[AP_NEXT2]], i8** %[[AP]]
|
||||
// WIN64-NEXT: bitcast i8* %[[AP_CUR2]] to { double, double }*
|
||||
// WIN64-NEXT: %[[CUR2:.*]] = bitcast i8* %[[AP_CUR2]] to { double, double }**
|
||||
// WIN64-NEXT: load { double, double }*, { double, double }** %[[CUR2]]
|
||||
struct foo d = __builtin_va_arg(ap, struct foo);
|
||||
// FREEBSD: %[[AP_CUR3:.*]] = load i8*, i8** %[[AP]]
|
||||
// FREEBSD-NEXT: %[[AP_NEXT3:.*]] = getelementptr inbounds i8, i8* %[[AP_CUR3]], i64 16
|
||||
// FREEBSD-NEXT: store i8* %[[AP_NEXT3]], i8** %[[AP]]
|
||||
// FREEBSD-NEXT: bitcast i8* %[[AP_CUR3]] to %[[STRUCT_FOO]]*
|
||||
// WIN64: %[[AP_CUR3:.*]] = load i8*, i8** %[[AP]]
|
||||
// WIN64-NEXT: %[[AP_NEXT3:.*]] = getelementptr inbounds i8, i8* %[[AP_CUR3]], i64 16
|
||||
// WIN64-NEXT: %[[AP_NEXT3:.*]] = getelementptr inbounds i8, i8* %[[AP_CUR3]], i64 8
|
||||
// WIN64-NEXT: store i8* %[[AP_NEXT3]], i8** %[[AP]]
|
||||
// WIN64-NEXT: bitcast i8* %[[AP_CUR3]] to %[[STRUCT_FOO]]*
|
||||
// WIN64-NEXT: %[[CUR3:.*]] = bitcast i8* %[[AP_CUR3]] to %[[STRUCT_FOO]]*
|
||||
// WIN64-NEXT: load %[[STRUCT_FOO]]*, %[[STRUCT_FOO]]** %[[CUR3]]
|
||||
__builtin_ms_va_list ap2;
|
||||
__builtin_ms_va_copy(ap2, ap);
|
||||
// FREEBSD: %[[AP_VAL:.*]] = load i8*, i8** %[[AP]]
|
||||
|
@ -88,12 +91,12 @@ void f5(int a, ...) {
|
|||
// WIN64-NEXT: bitcast i8* %[[AP_CUR]] to i32*
|
||||
double _Complex c = __builtin_va_arg(ap, double _Complex);
|
||||
// WIN64: %[[AP_CUR2:.*]] = load i8*, i8** %[[AP]]
|
||||
// WIN64-NEXT: %[[AP_NEXT2:.*]] = getelementptr inbounds i8, i8* %[[AP_CUR2]], i64 16
|
||||
// WIN64-NEXT: %[[AP_NEXT2:.*]] = getelementptr inbounds i8, i8* %[[AP_CUR2]], i64 8
|
||||
// WIN64-NEXT: store i8* %[[AP_NEXT2]], i8** %[[AP]]
|
||||
// WIN64-NEXT: bitcast i8* %[[AP_CUR2]] to { double, double }*
|
||||
struct foo d = __builtin_va_arg(ap, struct foo);
|
||||
// WIN64: %[[AP_CUR3:.*]] = load i8*, i8** %[[AP]]
|
||||
// WIN64-NEXT: %[[AP_NEXT3:.*]] = getelementptr inbounds i8, i8* %[[AP_CUR3]], i64 16
|
||||
// WIN64-NEXT: %[[AP_NEXT3:.*]] = getelementptr inbounds i8, i8* %[[AP_CUR3]], i64 8
|
||||
// WIN64-NEXT: store i8* %[[AP_NEXT3]], i8** %[[AP]]
|
||||
// WIN64-NEXT: bitcast i8* %[[AP_CUR3]] to %[[STRUCT_FOO]]*
|
||||
__builtin_va_list ap2;
|
||||
|
@ -124,7 +127,7 @@ void __attribute__((sysv_abi)) f6(__builtin_ms_va_list ap) {
|
|||
// FREEBSD-NEXT: store i8* %[[AP_NEXT2]], i8** %[[AP]]
|
||||
// FREEBSD-NEXT: bitcast i8* %[[AP_CUR2]] to { double, double }*
|
||||
// WIN64: %[[AP_CUR2:.*]] = load i8*, i8** %[[AP]]
|
||||
// WIN64-NEXT: %[[AP_NEXT2:.*]] = getelementptr inbounds i8, i8* %[[AP_CUR2]], i64 16
|
||||
// WIN64-NEXT: %[[AP_NEXT2:.*]] = getelementptr inbounds i8, i8* %[[AP_CUR2]], i64 8
|
||||
// WIN64-NEXT: store i8* %[[AP_NEXT2]], i8** %[[AP]]
|
||||
// WIN64-NEXT: bitcast i8* %[[AP_CUR2]] to { double, double }*
|
||||
struct foo d = __builtin_va_arg(ap, struct foo);
|
||||
|
@ -133,7 +136,7 @@ void __attribute__((sysv_abi)) f6(__builtin_ms_va_list ap) {
|
|||
// FREEBSD-NEXT: store i8* %[[AP_NEXT3]], i8** %[[AP]]
|
||||
// FREEBSD-NEXT: bitcast i8* %[[AP_CUR3]] to %[[STRUCT_FOO]]*
|
||||
// WIN64: %[[AP_CUR3:.*]] = load i8*, i8** %[[AP]]
|
||||
// WIN64-NEXT: %[[AP_NEXT3:.*]] = getelementptr inbounds i8, i8* %[[AP_CUR3]], i64 16
|
||||
// WIN64-NEXT: %[[AP_NEXT3:.*]] = getelementptr inbounds i8, i8* %[[AP_CUR3]], i64 8
|
||||
// WIN64-NEXT: store i8* %[[AP_NEXT3]], i8** %[[AP]]
|
||||
// WIN64-NEXT: bitcast i8* %[[AP_CUR3]] to %[[STRUCT_FOO]]*
|
||||
__builtin_ms_va_list ap2;
|
||||
|
|
Loading…
Reference in New Issue