replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

COFF: Make ArchiveFile::getMember thread-safe. 

This function is called SymbolTable::readObjects, so in order to
parallelize that function, we have to make this function thread-safe.

llvm-svn: 241420
This commit is contained in:
Rui Ueyama 2015-07-05 22:50:00 +00:00
parent 787e12aec1
commit adcde5384e
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lld/COFF/InputFiles.cpp
View File

@ -18,6 +18,7 @@
#include "llvm/Support/Debug.h"
#include "llvm/Support/Endian.h"
#include "llvm/Support/raw_ostream.h"
#include <mutex>
using namespace llvm::object;
using namespace llvm::support::endian;
@ -76,7 +77,9 @@ std::error_code ArchiveFile::parse() {
}
// Returns a buffer pointing to a member file containing a given symbol.
// This function is thread-safe.
ErrorOr<MemoryBufferRef> ArchiveFile::getMember(const Archive::Symbol *Sym) {
static std::mutex Mu;
auto ItOrErr = Sym->getMember();
if (auto EC = ItOrErr.getError())
return EC;
@ -84,7 +87,9 @@ ErrorOr<MemoryBufferRef> ArchiveFile::getMember(const Archive::Symbol *Sym) {
// Return an empty buffer if we have already returned the same buffer.
const char *StartAddr = It->getBuffer().data();
Mu.lock();
auto Pair = Seen.insert(StartAddr);
Mu.unlock();
if (!Pair.second)
return MemoryBufferRef();
return It->getMemoryBufferRef();