replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Verifier: Const-qualify Metadata, NFC 

llvm-svn: 228609
This commit is contained in:
Duncan P. N. Exon Smith 2015-02-09 21:30:05 +00:00
parent 950d8dfb04
commit ac3ed7afc9
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
llvm/lib/IR/Verifier.cpp
View File

@ -191,7 +191,7 @@ class Verifier : public InstVisitor<Verifier>, VerifierSupport {
SmallPtrSet<Instruction *, 16> InstsInThisBlock; SmallPtrSet<Instruction *, 16> InstsInThisBlock;
/// \brief Keep track of the metadata nodes that have been checked already. /// \brief Keep track of the metadata nodes that have been checked already.
SmallPtrSet<Metadata *, 32> MDNodes; SmallPtrSet<const Metadata *, 32> MDNodes;
/// \brief The personality function referenced by the LandingPadInsts. /// \brief The personality function referenced by the LandingPadInsts.
/// All LandingPadInsts within the same function must use the same /// All LandingPadInsts within the same function must use the same
@ -290,9 +290,9 @@ private:
void visitAliaseeSubExpr(SmallPtrSetImpl<const GlobalAlias *> &Visited, void visitAliaseeSubExpr(SmallPtrSetImpl<const GlobalAlias *> &Visited,
const GlobalAlias &A, const Constant &C); const GlobalAlias &A, const Constant &C);
void visitNamedMDNode(const NamedMDNode &NMD); void visitNamedMDNode(const NamedMDNode &NMD);
void visitMDNode(MDNode &MD); void visitMDNode(const MDNode &MD);
void visitMetadataAsValue(MetadataAsValue &MD, Function *F); void visitMetadataAsValue(const MetadataAsValue &MD, Function *F);
void visitValueAsMetadata(ValueAsMetadata &MD, Function *F); void visitValueAsMetadata(const ValueAsMetadata &MD, Function *F);
void visitComdat(const Comdat &C); void visitComdat(const Comdat &C);
void visitModuleIdents(const Module &M); void visitModuleIdents(const Module &M);
void visitModuleFlags(const Module &M); void visitModuleFlags(const Module &M);
@ -595,7 +595,7 @@ void Verifier::visitNamedMDNode(const NamedMDNode &NMD) {
} }
} }
void Verifier::visitMDNode(MDNode &MD) { void Verifier::visitMDNode(const MDNode &MD) {
// Only visit each node once. Metadata can be mutually recursive, so this // Only visit each node once. Metadata can be mutually recursive, so this
// avoids infinite recursion here, as well as being an optimization. // avoids infinite recursion here, as well as being an optimization.
if (!MDNodes.insert(&MD).second) if (!MDNodes.insert(&MD).second)
@ -622,7 +622,7 @@ void Verifier::visitMDNode(MDNode &MD) {
Assert1(MD.isResolved(), "All nodes should be resolved!", &MD); Assert1(MD.isResolved(), "All nodes should be resolved!", &MD);
} }
void Verifier::visitValueAsMetadata(ValueAsMetadata &MD, Function *F) { void Verifier::visitValueAsMetadata(const ValueAsMetadata &MD, Function *F) {
Assert1(MD.getValue(), "Expected valid value", &MD); Assert1(MD.getValue(), "Expected valid value", &MD);
Assert2(!MD.getValue()->getType()->isMetadataTy(), Assert2(!MD.getValue()->getType()->isMetadataTy(),
"Unexpected metadata round-trip through values", &MD, MD.getValue()); "Unexpected metadata round-trip through values", &MD, MD.getValue());
@ -648,7 +648,7 @@ void Verifier::visitValueAsMetadata(ValueAsMetadata &MD, Function *F) {
Assert1(ActualF == F, "function-local metadata used in wrong function", L); Assert1(ActualF == F, "function-local metadata used in wrong function", L);
} }
void Verifier::visitMetadataAsValue(MetadataAsValue &MDV, Function *F) { void Verifier::visitMetadataAsValue(const MetadataAsValue &MDV, Function *F) {
Metadata *MD = MDV.getMetadata(); Metadata *MD = MDV.getMetadata();
if (auto *N = dyn_cast<MDNode>(MD)) { if (auto *N = dyn_cast<MDNode>(MD)) {
visitMDNode(*N); visitMDNode(*N);