replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

PPC: Ignore spill/restore requests for VRSAVE (except on Darwin) 

This fixes PR16418, which reports that a function calling
__builtin_unwind_init() asserts. The cause is that this generates a
spill/restore for VRSAVE, and we support that only on Darwin (because VRSAVE is
only really used on Darwin).

The test case checks only that we don't crash. We can add correctness checks
once someone verifies what behavior the function is supposed to have.

llvm-svn: 185235
This commit is contained in:
Hal Finkel 2013-06-28 22:29:56 +00:00
parent 079fe209f5
commit ac1a24b508
2 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
llvm/lib/Target/PowerPC/PPCFrameLowering.cpp
View File

@ -1145,6 +1145,12 @@ PPCFrameLowering::spillCalleeSavedRegisters(MachineBasicBlock &MBB,
for (unsigned i = 0, e = CSI.size(); i != e; ++i) { for (unsigned i = 0, e = CSI.size(); i != e; ++i) {
unsigned Reg = CSI[i].getReg(); unsigned Reg = CSI[i].getReg();
// Only Darwin actually uses the VRSAVE register, but it can still appear
// here if, for example, @llvm.eh.unwind.init() is used. If we're not on
// Darwin, ignore it.
if (Reg == PPC::VRSAVE && !Subtarget.isDarwinABI())
continue;
// CR2 through CR4 are the nonvolatile CR fields. // CR2 through CR4 are the nonvolatile CR fields.
bool IsCRField = PPC::CR2 <= Reg && Reg <= PPC::CR4; bool IsCRField = PPC::CR2 <= Reg && Reg <= PPC::CR4;
@ -1294,6 +1300,12 @@ PPCFrameLowering::restoreCalleeSavedRegisters(MachineBasicBlock &MBB,
for (unsigned i = 0, e = CSI.size(); i != e; ++i) { for (unsigned i = 0, e = CSI.size(); i != e; ++i) {
unsigned Reg = CSI[i].getReg(); unsigned Reg = CSI[i].getReg();
// Only Darwin actually uses the VRSAVE register, but it can still appear
// here if, for example, @llvm.eh.unwind.init() is used. If we're not on
// Darwin, ignore it.
if (Reg == PPC::VRSAVE && !Subtarget.isDarwinABI())
continue;
if (Reg == PPC::CR2) { if (Reg == PPC::CR2) {
CR2Spilled = true; CR2Spilled = true;
// The spill slot is associated only with CR2, which is the // The spill slot is associated only with CR2, which is the

15
llvm/test/CodeGen/PowerPC/unwind-dw2.ll Normal file
View File

@ -0,0 +1,15 @@
; RUN: llc < %s
target datalayout = "E-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-f128:128:128-v128:128:128-n32:64"
target triple = "powerpc64-unknown-linux-gnu"
; Function Attrs: nounwind
define void @foo() #0 {
entry:
call void @llvm.eh.unwind.init()
ret void
}
; Function Attrs: nounwind
declare void @llvm.eh.unwind.init() #0
attributes #0 = { nounwind }