[DataFormatters] Adjusting libc++ std::list formatter to act better with pointers and references and adding a test to cover a previous related fix
Summary:
This previous fix 5469bda296
did not have a test since we did not have a reproducer.
This is related to how formatters deal with pointers and references. The added tests both the new behavior and covers the previous bug fix as well.
Differential Revision: https://reviews.llvm.org/D60588
llvm-svn: 359118
This commit is contained in:
parent
33d806a517
commit
abdb816b77
|
@ -162,6 +162,10 @@ class LibcxxListDataFormatterTestCase(TestBase):
|
|||
'[2] = ', '3',
|
||||
'[3] = ', '4'])
|
||||
|
||||
ListPtr = self.frame().FindVariable("list_ptr")
|
||||
self.assertTrue(ListPtr.GetChildAtIndex(
|
||||
0).GetValueAsUnsigned(0) == 1, "[0] = 1")
|
||||
|
||||
# check that MightHaveChildren() gets it right
|
||||
self.assertTrue(
|
||||
self.frame().FindVariable("numbers_list").MightHaveChildren(),
|
||||
|
|
|
@ -8,7 +8,8 @@ typedef std::list<std::string> string_list;
|
|||
int main()
|
||||
{
|
||||
int_list numbers_list;
|
||||
|
||||
std::list<int>* list_ptr = &numbers_list;
|
||||
|
||||
printf("// Set break point at this line.");
|
||||
(numbers_list.push_back(0x12345678));
|
||||
(numbers_list.push_back(0x11223344));
|
||||
|
|
|
@ -486,7 +486,7 @@ static void LoadLibCxxFormatters(lldb::TypeCategoryImplSP cpp_category_sp) {
|
|||
cpp_category_sp,
|
||||
lldb_private::formatters::LibcxxStdListSyntheticFrontEndCreator,
|
||||
"libc++ std::list synthetic children",
|
||||
ConstString("^std::__[[:alnum:]]+::list<.+>(( )?&)?$"), stl_synth_flags,
|
||||
ConstString("^std::__[[:alnum:]]+::list<.+>(( )?&)?$"), stl_deref_flags,
|
||||
true);
|
||||
AddCXXSynthetic(
|
||||
cpp_category_sp,
|
||||
|
|
Loading…
Reference in New Issue