CGP: Clear data structures at the end of a loop iteration instead of the beginning.
Clearing LargeOffsetGEPMap at the end fixes a bug where if a large offset GEP is in a dead basic block, we fail an assertion when trying to delete the block due to the asserting VH in LargeOffsetGEPMap. Differential Revision: https://reviews.llvm.org/D53464 llvm-svn: 345082
This commit is contained in:
parent
edc3201b11
commit
abd820a92b
|
@ -436,11 +436,6 @@ bool CodeGenPrepare::runOnFunction(Function &F) {
|
|||
bool MadeChange = true;
|
||||
while (MadeChange) {
|
||||
MadeChange = false;
|
||||
SeenChainsForSExt.clear();
|
||||
ValToSExtendedUses.clear();
|
||||
RemovedInsts.clear();
|
||||
LargeOffsetGEPMap.clear();
|
||||
LargeOffsetGEPID.clear();
|
||||
for (Function::iterator I = F.begin(); I != F.end(); ) {
|
||||
BasicBlock *BB = &*I++;
|
||||
bool ModifiedDTOnIteration = false;
|
||||
|
@ -460,6 +455,11 @@ bool CodeGenPrepare::runOnFunction(Function &F) {
|
|||
I->deleteValue();
|
||||
|
||||
EverMadeChange |= MadeChange;
|
||||
SeenChainsForSExt.clear();
|
||||
ValToSExtendedUses.clear();
|
||||
RemovedInsts.clear();
|
||||
LargeOffsetGEPMap.clear();
|
||||
LargeOffsetGEPID.clear();
|
||||
}
|
||||
|
||||
SunkAddrs.clear();
|
||||
|
|
|
@ -0,0 +1,22 @@
|
|||
; RUN: llc -o - %s | FileCheck %s
|
||||
|
||||
; CHECK: .LBB0_1:
|
||||
; CHECK: b .LBB0_1
|
||||
|
||||
target triple = "thumbv8m-unknown-linux-android"
|
||||
|
||||
define void @d(i32* %c) {
|
||||
entry:
|
||||
br i1 false, label %f.exit, label %i.d
|
||||
|
||||
i.d:
|
||||
br label %i.d
|
||||
|
||||
f.exit:
|
||||
%0 = getelementptr i32, i32* %c, i32 57
|
||||
br label %if.g
|
||||
|
||||
if.g:
|
||||
store i32 0, i32* %0
|
||||
ret void
|
||||
}
|
Loading…
Reference in New Issue