From ab6ccb5f886c4e1e898a4068e08e7d6993e01d4f Mon Sep 17 00:00:00 2001 From: Douglas Gregor Date: Tue, 17 Nov 2009 16:43:05 +0000 Subject: [PATCH] StringRef'ify CodeCompletionString llvm-svn: 89102 --- .../include/clang/Sema/CodeCompleteConsumer.h | 18 +++++++++--------- clang/lib/Sema/CodeCompleteConsumer.cpp | 10 ++++++---- 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/clang/include/clang/Sema/CodeCompleteConsumer.h b/clang/include/clang/Sema/CodeCompleteConsumer.h index 5d27b1a90fde..43ff6869184d 100644 --- a/clang/include/clang/Sema/CodeCompleteConsumer.h +++ b/clang/include/clang/Sema/CodeCompleteConsumer.h @@ -109,19 +109,19 @@ public: Chunk(ChunkKind Kind, llvm::StringRef Text = ""); /// \brief Create a new text chunk. - static Chunk CreateText(const char *Text); + static Chunk CreateText(llvm::StringRef Text); /// \brief Create a new optional chunk. static Chunk CreateOptional(std::auto_ptr Optional); /// \brief Create a new placeholder chunk. - static Chunk CreatePlaceholder(const char *Placeholder); + static Chunk CreatePlaceholder(llvm::StringRef Placeholder); /// \brief Create a new informative chunk. - static Chunk CreateInformative(const char *Informative); + static Chunk CreateInformative(llvm::StringRef Informative); /// \brief Create a new current-parameter chunk. - static Chunk CreateCurrentParameter(const char *CurrentParameter); + static Chunk CreateCurrentParameter(llvm::StringRef CurrentParameter); /// \brief Destroy this chunk, deallocating any memory it owns. void Destroy(); @@ -156,13 +156,13 @@ public: /// \brief Add a new typed-text chunk. /// The text string will be copied. - void AddTypedTextChunk(const char *Text) { + void AddTypedTextChunk(llvm::StringRef Text) { Chunks.push_back(Chunk(CK_TypedText, Text)); } /// \brief Add a new text chunk. /// The text string will be copied. - void AddTextChunk(const char *Text) { + void AddTextChunk(llvm::StringRef Text) { Chunks.push_back(Chunk::CreateText(Text)); } @@ -173,19 +173,19 @@ public: /// \brief Add a new placeholder chunk. /// The placeholder text will be copied. - void AddPlaceholderChunk(const char *Placeholder) { + void AddPlaceholderChunk(llvm::StringRef Placeholder) { Chunks.push_back(Chunk::CreatePlaceholder(Placeholder)); } /// \brief Add a new informative chunk. /// The text will be copied. - void AddInformativeChunk(const char *Text) { + void AddInformativeChunk(llvm::StringRef Text) { Chunks.push_back(Chunk::CreateInformative(Text)); } /// \brief Add a new current-parameter chunk. /// The text will be copied. - void AddCurrentParameterChunk(const char *CurrentParameter) { + void AddCurrentParameterChunk(llvm::StringRef CurrentParameter) { Chunks.push_back(Chunk::CreateCurrentParameter(CurrentParameter)); } diff --git a/clang/lib/Sema/CodeCompleteConsumer.cpp b/clang/lib/Sema/CodeCompleteConsumer.cpp index 3529ece25740..88ac4e49cf9e 100644 --- a/clang/lib/Sema/CodeCompleteConsumer.cpp +++ b/clang/lib/Sema/CodeCompleteConsumer.cpp @@ -22,7 +22,9 @@ #include #include #include + using namespace clang; +using llvm::StringRef; //===----------------------------------------------------------------------===// // Code completion string implementation @@ -86,7 +88,7 @@ CodeCompletionString::Chunk::Chunk(ChunkKind Kind, llvm::StringRef Text) } CodeCompletionString::Chunk -CodeCompletionString::Chunk::CreateText(const char *Text) { +CodeCompletionString::Chunk::CreateText(StringRef Text) { return Chunk(CK_Text, Text); } @@ -100,18 +102,18 @@ CodeCompletionString::Chunk::CreateOptional( } CodeCompletionString::Chunk -CodeCompletionString::Chunk::CreatePlaceholder(const char *Placeholder) { +CodeCompletionString::Chunk::CreatePlaceholder(StringRef Placeholder) { return Chunk(CK_Placeholder, Placeholder); } CodeCompletionString::Chunk -CodeCompletionString::Chunk::CreateInformative(const char *Informative) { +CodeCompletionString::Chunk::CreateInformative(StringRef Informative) { return Chunk(CK_Informative, Informative); } CodeCompletionString::Chunk CodeCompletionString::Chunk::CreateCurrentParameter( - const char *CurrentParameter) { + StringRef CurrentParameter) { return Chunk(CK_CurrentParameter, CurrentParameter); }