From a955c02c9b689f429876181b4618980f42023ac2 Mon Sep 17 00:00:00 2001 From: Evan Cheng Date: Tue, 19 Jun 2007 21:45:13 +0000 Subject: [PATCH] Avoid if-converting simple block that ends with unconditional branch or fallthrough unless it branches / falls to the 'false' block. Not profitable, may end up increasing code size. llvm-svn: 37660 --- llvm/lib/CodeGen/IfConversion.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/llvm/lib/CodeGen/IfConversion.cpp b/llvm/lib/CodeGen/IfConversion.cpp index 965cf6af191c..64328d6e04f4 100644 --- a/llvm/lib/CodeGen/IfConversion.cpp +++ b/llvm/lib/CodeGen/IfConversion.cpp @@ -399,6 +399,9 @@ bool IfConverter::ValidSimple(BBInfo &TrueBBI, unsigned &Dups) const { if (TrueBBI.IsBeingAnalyzed || TrueBBI.IsDone) return false; + if (TrueBBI.IsBrAnalyzable) + return false; + if (TrueBBI.BB->pred_size() > 1) { if (TrueBBI.CannotBeCopied || TrueBBI.NonPredSize > TLI->getIfCvtDupBlockSizeLimit()) @@ -406,7 +409,7 @@ bool IfConverter::ValidSimple(BBInfo &TrueBBI, unsigned &Dups) const { Dups = TrueBBI.NonPredSize; } - return !blockAlwaysFallThrough(TrueBBI) && TrueBBI.BrCond.size() == 0; + return true; } /// ValidTriangle - Returns true if the 'true' and 'false' blocks (along