From a736c001b6086d419290fe4decc01dad79b4d37b Mon Sep 17 00:00:00 2001 From: Devang Patel Date: Tue, 26 Feb 2008 19:38:17 +0000 Subject: [PATCH] Use SmallVector while constructing ReturnInst. llvm-svn: 47619 --- llvm/include/llvm/Instructions.h | 3 +++ llvm/lib/Bitcode/Reader/BitcodeReader.cpp | 6 ++++-- llvm/lib/VMCore/Instructions.cpp | 18 ++++++++++++++++++ 3 files changed, 25 insertions(+), 2 deletions(-) diff --git a/llvm/include/llvm/Instructions.h b/llvm/include/llvm/Instructions.h index 316d6b5a091c..2b7241e72536 100644 --- a/llvm/include/llvm/Instructions.h +++ b/llvm/include/llvm/Instructions.h @@ -1400,6 +1400,9 @@ public: ReturnInst(const std::vector &retVals); ReturnInst(const std::vector &retVals, Instruction *InsertBefore); ReturnInst(const std::vector &retVals, BasicBlock *InsertAtEnd); + ReturnInst(Value * const* retVals, unsigned N); + ReturnInst(Value * const* retVals, unsigned N, Instruction *InsertBefore); + ReturnInst(Value * const* retVals, unsigned N, BasicBlock *InsertAtEnd); explicit ReturnInst(BasicBlock *InsertAtEnd); virtual ~ReturnInst(); diff --git a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp index 487a135509c4..61e0ab989890 100644 --- a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp +++ b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp @@ -21,6 +21,7 @@ #include "llvm/ParamAttrsList.h" #include "llvm/AutoUpgrade.h" #include "llvm/ADT/SmallString.h" +#include "llvm/ADT/SmallVector.h" #include "llvm/Support/MathExtras.h" #include "llvm/Support/MemoryBuffer.h" using namespace llvm; @@ -1344,7 +1345,7 @@ bool BitcodeReader::ParseFunctionBody(Function *F) { break; } else { unsigned OpNum = 0; - std::vector Vs; + SmallVector Vs; do { Value *Op = NULL; if (getValueTypePair(Record, OpNum, NextValueNo, Op)) @@ -1352,7 +1353,8 @@ bool BitcodeReader::ParseFunctionBody(Function *F) { Vs.push_back(Op); } while(OpNum != Record.size()); - I = new ReturnInst(Vs); + // SmallVector Vs has at least one element. + I = new ReturnInst(&Vs[0], Vs.size()); break; } } diff --git a/llvm/lib/VMCore/Instructions.cpp b/llvm/lib/VMCore/Instructions.cpp index ffd93dbc6227..012aad189eb0 100644 --- a/llvm/lib/VMCore/Instructions.cpp +++ b/llvm/lib/VMCore/Instructions.cpp @@ -618,6 +618,24 @@ ReturnInst::ReturnInst(const std::vector &retVals) init(&retVals[0], retVals.size()); } +ReturnInst::ReturnInst(Value * const* retVals, unsigned N, + Instruction *InsertBefore) + : TerminatorInst(Type::VoidTy, Instruction::Ret, &RetVal, N, InsertBefore) { + if (N != 0) + init(retVals, N); +} +ReturnInst::ReturnInst(Value * const* retVals, unsigned N, + BasicBlock *InsertAtEnd) + : TerminatorInst(Type::VoidTy, Instruction::Ret, &RetVal, N, InsertAtEnd) { + if (N != 0) + init(retVals, N); +} +ReturnInst::ReturnInst(Value * const* retVals, unsigned N) + : TerminatorInst(Type::VoidTy, Instruction::Ret, &RetVal, N) { + if (N != 0) + init(retVals, N); +} + void ReturnInst::init(Value * const* retVals, unsigned N) { assert (N > 0 && "Invalid operands numbers in ReturnInst init");