diff --git a/clang/lib/AST/DeclObjC.cpp b/clang/lib/AST/DeclObjC.cpp index 7e2a99fb26b2..9e803b71e164 100644 --- a/clang/lib/AST/DeclObjC.cpp +++ b/clang/lib/AST/DeclObjC.cpp @@ -345,7 +345,8 @@ void ObjCInterfaceDecl::CollectObjCIvars(std::vector &Fields) { for (ObjCInterfaceDecl::ivar_iterator I = ivar_begin(), E = ivar_end(); I != E; ++I) { ObjCIvarDecl *IVDecl = (*I); - Fields.push_back(cast(IVDecl)); + if (!IVDecl->isInvalidDecl()) + Fields.push_back(cast(IVDecl)); } } @@ -390,7 +391,8 @@ void ObjCInterfaceDecl::addRecordToClass(ASTContext &Context) /// FIXME! Can do collection of ivars and adding to the record while /// doing it. for (unsigned int i = 0; i != RecFields.size(); i++) { - FieldDecl *Field = FieldDecl::Create(Context, RD, SourceLocation(), + FieldDecl *Field = FieldDecl::Create(Context, RD, + RecFields[i]->getLocation(), RecFields[i]->getIdentifier(), RecFields[i]->getType(), RecFields[i]->getBitWidth(), false, 0); diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp index 5e0edcd1ecf5..0d48c626125e 100644 --- a/clang/lib/Sema/SemaDecl.cpp +++ b/clang/lib/Sema/SemaDecl.cpp @@ -3091,6 +3091,25 @@ void Sema::ActOnFields(Scope* S, if (ObjCInterfaceDecl *ID = dyn_cast(EnclosingDecl)) { ID->addInstanceVariablesToClass(ClsFields, RecFields.size(), RBrac); ID->addRecordToClass(Context); + // Must enforce the rule that ivars in the base classes may not be + // duplicates. + FieldIDs.clear(); + RecordDecl *RD = ID->getRecordForDecl(); + for (RecordDecl::field_iterator i = RD->field_begin(), + e = RD->field_end(); i != e; ++i) { + FieldDecl *FD = *i; + if (IdentifierInfo *II = FD->getIdentifier()) + if (!FieldIDs.insert(II)) { + Diag(FD->getLocation(), diag::err_duplicate_member) << II; + FD->setInvalidDecl(); + for (RecordDecl::field_iterator j = RD->field_begin(), + e1 = RD->field_end(); j != e1; ++j) + if (II == (*j)->getIdentifier()) { + Diag((*j)->getLocation(), diag::note_previous_definition); + break; + } + } + } } else if (ObjCImplementationDecl *IMPDecl = dyn_cast(EnclosingDecl)) { diff --git a/clang/test/SemaObjC/duplicate-ivar-check.m b/clang/test/SemaObjC/duplicate-ivar-check.m new file mode 100644 index 000000000000..ea42e9e277b7 --- /dev/null +++ b/clang/test/SemaObjC/duplicate-ivar-check.m @@ -0,0 +1,20 @@ +// RUN: clang -fsyntax-only -verify %s + +@interface B1 { +@public + double fill_B; // expected-note {{previous definition is here}} +} +@end + +@interface B : B1 { +@public + int one; // expected-note {{previous definition is here}} + int one; // expected-error {{duplicate member 'one'}} +} +@end + +@interface A : B { +@public + int fill_B; // expected-error {{duplicate member 'fill_B'}} +} +@end