replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Don't warn about functions redeclared without the dllimport attribute when 

-fms-extensions is enabled.  Fixes <rdar://problem/7669559>.

llvm-svn: 96721
This commit is contained in:
Ted Kremenek 2010-02-21 05:12:53 +00:00
parent 3c29aff9ff
commit a3cfc4d1e1
2 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
clang/lib/Sema/SemaDecl.cpp
View File

@ -4136,7 +4136,11 @@ Sema::DeclPtrTy Sema::ActOnStartOfFunctionDef(Scope *FnBodyScope, DeclPtrTy D) {
<< "dllimport";
FD->setInvalidDecl();
return DeclPtrTy::make(FD);
} else {
}
// Visual C++ appears to not think this is an issue, so only issue
// a warning when Microsoft extensions are disabled.
if (!LangOpts.Microsoft) {
// If a symbol previously declared dllimport is later defined, the
// attribute is ignored in subsequent references, and a warning is
// emitted.

19
clang/test/Rewriter/missing-dllimport.c Normal file
View File

@ -0,0 +1,19 @@
// RUN: %clang_cc1 -triple i686-pc-win32 -fms-extensions -fsyntax-only %s 2>&1 | FileCheck -check-prefix=CHECK-NEG %s
// RUN: %clang_cc1 -triple i686-pc-win32 -fsyntax-only %s 2>&1 | FileCheck -check-prefix=CHECK-POS %s
// Do not report that 'foo()' is redeclared without dllimport attribute with -fms-extensions
// specified. Addresses <rdar://problem/7653912>.
__declspec(dllimport) int __cdecl foo(void);
inline int __cdecl foo() { return 0; }
// This function is added just to trigger a diagnostic. This way we can test how many
// diagnostics we expect.
void bar() { return 1; }
// CHECK-NEG: warning: void function 'bar' should not return a value
// CHECK-NEG: 1 diagnostic generated
// CHECK-POS: warning: 'foo' redeclared without dllimport attribute: previous dllimport ignored
// CHECK-POS: warning: void function 'bar' should not return a value
// CHECK-POS: 2 diagnostics generated